Update dependencies and fix lint stuff #511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
# Conflicts: # library/quality/quality.gradle
Signed-off-by: Alex Saveau <[email protected]>
# Conflicts: # auth/src/main/java/com/firebase/ui/auth/ui/AppCompatBase.java # build.gradle # library/quality/quality.gradle
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
SUPERCILEX
commented
Jan 11, 2017
| @@ -43,7 +43,6 @@ dependencies { | |||
| // The following dependencies are not required to use the Firebase UI library. | |||
| // They are used to make some aspects of the demo app implementation simpler for | |||
| // demonstrative purposes, and you may find them useful in your own apps; YMMV. | |||
| compile 'com.github.bumptech.glide:glide:3.7.0' | |||
There was a problem hiding this comment.
The following dependencies are not required to use the Firebase UI library.
That's no longer true: Glide is included in firebase-ui-storage.
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@samtstern I didn't forget! I removed the
disable 'RestrictedApi'hack and updated jfrog.