Version 1.1.0 qa #515
Merged
Version 1.1.0 qa #515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ebase#504)" This reverts commit 97ac613.
* The auth method picker screen looks really bad in landscape,
put everything in a ScrollView as a temporary measure until
we can think of some better UX
* TestUtils did not compile, had to change some code
and move the package
Change-Id: I84d3d974390774a7ea3c7cf5deb444b022bb7fd8
|
@puf or @SUPERCILEX PTAL |
Change-Id: I1a43b8cd08672253a1a749cbb3e256da0a7621d7
SUPERCILEX
reviewed
Jan 12, 2017
| @@ -1,36 +1,33 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <LinearLayout | |||
| xmlns:android="http://schemas.android.com/apk/res/android" | |||
| <ScrollView xmlns:android="http://schemas.android.com/apk/res/android" | |||
There was a problem hiding this comment.
This is awesome, thanks!
samtstern
added a commit
to samtstern/FirebaseUI-Android
that referenced
this pull request
Jan 13, 2017
Change-Id: I4e5d3ed02710a2f3681816be8e7df122f977fa65
samtstern
added a commit
that referenced
this pull request
Jan 13, 2017
Undo layout changes from #515
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did some QA, things are looking mostly great. I had to revert a PR regarding NightMode since it was messing up all of our non-nightmode styles and I would rather be safe than sorry.