Skip to content

Start safe ID at non-default value for getSafeAutoManageId #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 6, 2017
Merged

Start safe ID at non-default value for getSafeAutoManageId #578

merged 6 commits into from
Feb 6, 2017

Conversation

SUPERCILEX
Copy link
Collaborator

@samtstern See #575 (comment). I think this is the best course of action, any objections?

@SUPERCILEX SUPERCILEX changed the title Start safe ID at 10 for getSafeAutoManageId Start safe ID at non-default value for getSafeAutoManageId Feb 6, 2017
/**
* @return a safe id for {@link GoogleApiClient.Builder#enableAutoManage(FragmentActivity, int,
* GoogleApiClient.OnConnectionFailedListener)}
*/
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any objections to leaving the documentation?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope documentation is always good

@samtstern samtstern merged commit 68f0f64 into firebase:version-1.2.0-dev Feb 6, 2017
@SUPERCILEX SUPERCILEX deleted the google-api-client branch February 6, 2017 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants