Skip to content

When linking two accounts, use the provider the user last added to their account instead of the first one #701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 27, 2017

Conversation

SUPERCILEX
Copy link
Collaborator

Since the last provider the user adds to their account is likely to be the one that is most practical for them to use, I think this change would provider better UX.

@samtstern @amandle What are your thoughts on this?

@SUPERCILEX
Copy link
Collaborator Author

@samtstern What do you think about this one?

@samtstern
Copy link
Contributor

@SUPERCILEX I like the idea, but I have to draw the line on 2.0.0 somewhere and I am drawing it at "things we have already done + phone auth" :-)

@SUPERCILEX
Copy link
Collaborator Author

@samtstern cool beans, that works for me! 😀

@SUPERCILEX SUPERCILEX changed the base branch from version-2.0.0-dev to version-2.1.0-dev June 13, 2017 02:05
@SUPERCILEX
Copy link
Collaborator Author

@samtstern What are your thoughts on this?

I'm wondering if using our own custom ranking system would simply be better. We know that Google auth is way easier and faster, then I would say Facebook, then Twitter, then email. What do you think?

@samtstern samtstern added this to the 2.1.0 milestone Jun 26, 2017
@samtstern
Copy link
Contributor

@SUPERCILEX I think custom ranking gets a little political, I don't want to favor one IDP over another because of implementation details.

I am fine to merge this into 2.1.0 now if you're happy with it as-is.

@SUPERCILEX
Copy link
Collaborator Author

SUPERCILEX commented Jun 26, 2017

I think custom ranking gets a little political

Haha, yeah good catch! 😂

@samtstern yup, I still think using the user's newer provider is better then their original one so go for it! 😀

@samtstern samtstern merged commit baa2d51 into firebase:version-2.1.0-dev Jun 27, 2017
@SUPERCILEX SUPERCILEX deleted the last-linked branch June 27, 2017 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants