Skip to content

Update FirebaseListAdapter to use Context instead of Activity #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 22, 2017

Conversation

WillieCubed
Copy link
Contributor

Fixes #773.

@samtstern samtstern merged commit 6d2c1ae into firebase:version-2.1.0-dev Jun 22, 2017
@WillieCubed
Copy link
Contributor Author

I know this would be a breaking change, but is there any reason we can't just use LayoutInflater.from(view.getContext()).inflate(mLayout, viewGroup, false); instead of having a dedicated constructor parameter? This would of course be changed in the next major release. (@samtstern)

@samtstern
Copy link
Contributor

@TheCraftKid you're probably right, but given that it's easy to get a Context anywhere you'd want to use ListAdapter I don't know if that's worth the break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants