-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Button style #795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Button style #795
Conversation
I added the style to this button
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
This LGTM. I think we can merge this into 2.1.1. (Not sure how we missed this for 2.1.0) |
@@ -23,6 +23,7 @@ | |||
|
|||
<Button | |||
android:id="@+id/welcome_back_idp_button" | |||
style="@style/FirebaseUI.Button" | |||
android:layout_width="wrap_content" | |||
android:layout_height="wrap_content" | |||
android:layout_gravity="end" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are adding the style, we can remove all of the following:
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_gravity="end"
@TheCraftKid I was waiting on the CLA, which was never signed by @kayzenkayzen. If it remains unsigned we can just replicate this PR ourselves. |
To whoever does this PR: we should also probably change the gravity to be |
Whoops, didn't notice the unsigned CLA. I think we should give this until next Monday or Tuesday and then replicate the PR. |
Closed via #822 |
I added the style to this button
Hey there! So you want to contribute to FirebaseUI? Before you file this pull request, follow these steps:
./gradlew check
to ensure the Travis build passes.