Skip to content

Button style #795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Button style #795

wants to merge 1 commit into from

Conversation

kayzenkayzen
Copy link

I added the style to this button

Hey there! So you want to contribute to FirebaseUI? Before you file this pull request, follow these steps:

  • Read the contribution guidelines.
  • Run ./gradlew check to ensure the Travis build passes.
  • If this has been discussed in an issue, make sure to mention the issue number here. If not, go file an issue about this to make sure this is a desirable change.
  • If this is a new feature please co-ordinate with someone on FirebaseUI-iOS to make sure that we can implement this on both platforms and maintain feature parity.

I added the style to this button
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@WillieCubed
Copy link
Contributor

WillieCubed commented Jul 21, 2017

This LGTM. I think we can merge this into 2.1.1. (Not sure how we missed this for 2.1.0)
(@samtstern, @SUPERCILEX)

@@ -23,6 +23,7 @@

<Button
android:id="@+id/welcome_back_idp_button"
style="@style/FirebaseUI.Button"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_gravity="end"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are adding the style, we can remove all of the following:

android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_gravity="end"

@samtstern
Copy link
Contributor

@TheCraftKid I was waiting on the CLA, which was never signed by @kayzenkayzen.

If it remains unsigned we can just replicate this PR ourselves.

@SUPERCILEX
Copy link
Collaborator

To whoever does this PR: we should also probably change the gravity to be end instead of right and we can also remove this unessassary string.

@WillieCubed
Copy link
Contributor

WillieCubed commented Jul 21, 2017

Whoops, didn't notice the unsigned CLA. I think we should give this until next Monday or Tuesday and then replicate the PR.

@SUPERCILEX SUPERCILEX mentioned this pull request Jul 25, 2017
@samtstern
Copy link
Contributor

Closed via #822

@samtstern samtstern closed this Jul 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants