Skip to content

Update buildToolsVersion to 26.0.1, supportLibrary and SdkVersion to 26 #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 3, 2017

Conversation

annalabellarte
Copy link
Contributor

Closes #848

@samtstern
Copy link
Contributor

@annalabellarte thanks for sending this! Will merge once the build passes.

@samtstern samtstern merged commit de16b18 into firebase:master Aug 3, 2017
@SUPERCILEX
Copy link
Collaborator

@samtstern Ahhhhh, I'm too late. I was going to say there's far more we need to do before we can just update the target sdk version, but I guess it'll force me to submit a PR. 😄 I was holding out because we'll need to update all our findViewByIds, Robolectric, add autofill hints, update the sample with adaptive icons, etc. There's a lot! 😆

@samtstern
Copy link
Contributor

All of those are enabled by this, but none of them are required right? The only required API 26 changes I know there are big changes to background work execution, but that should not apply to us.

Here's the big list:
https://developer.android.com/preview/behavior-changes.html

@SUPERCILEX
Copy link
Collaborator

@samtstern True, though I have seen autofill make mistakes and show incorrect suggestions at times. That's the main thing we have to test for compatibility, but I'll just get the other stuff done as well since it was on my TODO list anyway. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants