Remove the cache key mapping for old fullpath style cache keys

Author: dreampiggy

Storage/FirebaseStorageUI/UIImageView+FirebaseStorage.m

@@ -17,7 +17,7 @@
 #import "UIImageView+FirebaseStorage.h"
 #import "SDWebImageFirebaseLoader.h"
 
-static SDWebImageManager *SharedFirebaseWebImageManager(void) {
+static SDWebImageManager *DefaultFirebaseWebImageManager(void) {
   static dispatch_once_t onceToken;
   static SDWebImageManager *manager;
   dispatch_once(&onceToken, ^{
@@ -121,14 +121,12 @@ - (void)sd_setImageWithStorageReference:(FIRStorageReference *)storageRef
   } else {
     mutableContext = [NSMutableDictionary dictionary];
   }
-  mutableContext[SDWebImageContextCustomManager] = SharedFirebaseWebImageManager();
-  mutableContext[SDWebImageContextFirebaseMaxImageSize] = @(size);
-  
-  // TODO: Current version use `fullpath` as cache key, but not the URL. Do we need to keep compabitle ?
-  SDWebImageCacheKeyFilter *cacheKeyFilter = [SDWebImageCacheKeyFilter cacheKeyFilterWithBlock:^NSString * _Nullable(NSURL * _Nonnull url) {
-    return url.sd_storageReference.fullPath;
-  }];
-  mutableContext[SDWebImageContextCacheKeyFilter] = cacheKeyFilter;
+  if (!mutableContext[SDWebImageContextCustomManager]) {
+    mutableContext[SDWebImageContextCustomManager] = DefaultFirebaseWebImageManager();
+  }
+  if (!mutableContext[SDWebImageContextFirebaseMaxImageSize]) {
+    mutableContext[SDWebImageContextFirebaseMaxImageSize] = @(size);
+  }
 
   [self sd_setImageWithURL:url placeholderImage:placeholder options:options context:[mutableContext copy] progress:^(NSInteger receivedSize, NSInteger expectedSize, NSURL * _Nullable targetURL) {
     if (progressBlock) {

Storage/FirebaseStorageUITests/FUIImageViewCategoryTests.m

@@ -62,7 +62,8 @@ - (void)testItDoesNotCreateADownloadIfImageIsCached {
   .andReturn(OCMClassMock([FIRStorageDownloadTask class]));
   UIImage *image = [[UIImage alloc] init];
   self.cache = [SDImageCache sharedImageCache];
-  [self.cache storeImage:image forKey:self.ref.fullPath completion:nil];
+  NSURL *url = [NSURL sd_URLWithStorageReference:self.ref];
+  [self.cache storeImage:image forKey:url.absoluteString completion:nil];
   [self.imageView sd_setImageWithStorageReference:self.ref
                                      maxImageSize:4096
                                  placeholderImage:nil
@@ -97,13 +98,13 @@ - (void)testItSetsAPlaceholder {
 
 - (void)testItCancelsTheCurrentDownloadWhenSettingAnImage {
   OCMStub([self.ref dataWithMaxSize:512 completion:[OCMArg any]])
-  .andReturn(OCMClassMock([FIRStorageDownloadTask class]));
+  .andReturn(OCMClassMock(NSClassFromString(@"FIRStorageDownloadTask"))); // Must using `NSClassFromString` instead of `FIRStorageDownloadTask.class` for OCMock, or the isKindOfClass: failed.
   [self.imageView sd_setImageWithStorageReference:self.ref
                                      maxImageSize:512
                                  placeholderImage:nil
                                           options:SDWebImageFromLoaderOnly // Disable cache
                                        completion:nil];
-  FIRStorageDownloadTask *download = self.imageView.sd_currentDownloadTask; // TODO: using OCMock, the `isKindOfClass:` return NO and break the real logic. What about using the actual request ?
+  FIRStorageDownloadTask *download = self.imageView.sd_currentDownloadTask;
   self.ref = OCMClassMock([FIRStorageReference class]);
   [self.imageView sd_setImageWithStorageReference:self.ref
                                      maxImageSize:512