Skip to content

Commit 3ab34cb

Browse files
committed
Update some small comments to match the behavior
1 parent b50350a commit 3ab34cb

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

Storage/FirebaseStorageUI/SDWebImageFIRStorageLoader.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ - (BOOL)canLoadWithURL:(NSURL *)url {
5858
}
5959
// Download the image from Firebase Storage
6060

61-
// TODO: Support progressive image loading using the `GTMSessionFetcher`
61+
// TODO: Support progressive image loading using the `GTMSessionFetcher.downloadedData` with `SDImageLoaderDecodeProgressiveImageData`
6262
FIRStorageDownloadTask * download = [storageRef dataWithMaxSize:size
6363
completion:^(NSData * _Nullable data, NSError * _Nullable error) {
6464
if (error) {

Storage/FirebaseStorageUI/UIImageView+FirebaseStorage.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,12 @@ NS_ASSUME_NONNULL_BEGIN
2525

2626
/**
2727
* The current download task, if the image view is downloading an image.
28-
* Must be invoked on the main queue.
2928
*/
3029
@property (nonatomic, readonly, nullable) FIRStorageDownloadTask *sd_currentDownloadTask;
3130

3231
/**
3332
* Sets the image view's image to an image downloaded from the Firebase Storage reference.
33+
* Must be invoked on the main queue.
3434
*
3535
* @param storageRef A Firebase Storage reference containing an image.
3636
*/

Storage/FirebaseStorageUI/UIImageView+FirebaseStorage.m

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
#import "UIImageView+FirebaseStorage.h"
1818
#import "SDWebImageFIRStorageLoader.h"
1919

20-
static SDWebImageManager *DefaultFirebaseWebImageManager(void) {
20+
static SDWebImageManager *DefaultWebImageManager(void) {
2121
static dispatch_once_t onceToken;
2222
static SDWebImageManager *manager;
2323
dispatch_once(&onceToken, ^{
@@ -122,7 +122,7 @@ - (void)sd_setImageWithStorageReference:(FIRStorageReference *)storageRef
122122
mutableContext = [NSMutableDictionary dictionary];
123123
}
124124
if (!mutableContext[SDWebImageContextCustomManager]) {
125-
mutableContext[SDWebImageContextCustomManager] = DefaultFirebaseWebImageManager();
125+
mutableContext[SDWebImageContextCustomManager] = DefaultWebImageManager();
126126
}
127127
if (!mutableContext[SDWebImageContextFIRStorageMaxImageSize]) {
128128
mutableContext[SDWebImageContextFIRStorageMaxImageSize] = @(size);

0 commit comments

Comments
 (0)