Skip to content

Commit 759341b

Browse files
committed
Update FirebaseUI/Auth 2.0, synced @122379019.
Change-Id: I11fcce1458c533f3d8b0913255fd592db1b3812e
1 parent a4af39b commit 759341b

File tree

7 files changed

+13
-79
lines changed

7 files changed

+13
-79
lines changed

FirebaseUI/Auth/AuthUI/Source/FIRAuthPickerViewController.m

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ - (void)viewDidLoad {
8181
action:@selector(cancel)];
8282
self.navigationItem.leftBarButtonItem = cancelBarButton;
8383

84-
NSInteger numberOfButtons = self.authUI.signInProviders.count;
84+
NSInteger numberOfButtons = self.authUI.providers.count;
8585
BOOL showEmailButton = !self.authUI.signInWithEmailHidden;
8686
if (showEmailButton) {
8787
++numberOfButtons;
@@ -93,7 +93,7 @@ - (void)viewDidLoad {
9393
[self.view addSubview:_buttonContainerView];
9494

9595
CGRect buttonFrame = CGRectMake(0, 0, kSignInButtonWidth, kSignInButtonHeight);
96-
for (id<FIRAuthProviderUI> providerUI in self.authUI.signInProviders) {
96+
for (id<FIRAuthProviderUI> providerUI in self.authUI.providers) {
9797
UIButton *providerButton =
9898
[[FIRAuthUISignInButton alloc] initWithFrame:buttonFrame providerUI:providerUI];
9999
[providerButton addTarget:self
@@ -283,8 +283,8 @@ - (void)handleAccountLinkingForEmail:(NSString *)email
283283
#pragma mark - Utilities
284284

285285
- (nullable id<FIRAuthProviderUI>)providerWithID:(NSString *)providerID {
286-
NSArray<id<FIRAuthProviderUI>> *signInProviders = self.authUI.signInProviders;
287-
for (id<FIRAuthProviderUI> provider in signInProviders) {
286+
NSArray<id<FIRAuthProviderUI>> *providers = self.authUI.providers;
287+
for (id<FIRAuthProviderUI> provider in providers) {
288288
if ([provider.providerID isEqual:providerID]) {
289289
return provider;
290290
}

FirebaseUI/Auth/AuthUI/Source/FIRAuthUI.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -84,10 +84,10 @@ typedef void (^FIRAuthUIResultCallback)(FIRUser *_Nullable user, NSError *_Nulla
8484
*/
8585
@property(nonatomic, weak, readonly, nullable) FIRAuth *auth;
8686

87-
/** @property signInProviders
87+
/** @property providers
8888
@brief The @c FIRAuthProviderUI implementations to use for sign-in.
8989
*/
90-
@property(nonatomic, copy) NSArray<id<FIRAuthProviderUI>> *signInProviders;
90+
@property(nonatomic, copy) NSArray<id<FIRAuthProviderUI>> *providers;
9191

9292
/** @property signInWithEmailHidden
9393
@brief Whether to hide the "Sign in with email" option, defaults to NO.
@@ -102,11 +102,11 @@ typedef void (^FIRAuthUIResultCallback)(FIRUser *_Nullable user, NSError *_Nulla
102102
*/
103103
@property(nonatomic, strong, nullable) NSBundle *customStringsBundle;
104104

105-
/** @property termsOfServiceURL
105+
/** @property TOSURL
106106
@brief The URL of your app's Terms of Service. If not nil, a Terms of Service notice is
107107
displayed on the email/password account creation screen.
108108
*/
109-
@property(nonatomic, copy, nullable) NSURL *termsOfServiceURL;
109+
@property(nonatomic, copy, nullable) NSURL *TOSURL;
110110

111111
/** @property delegate
112112
@brief A delegate that receives callbacks or provides custom UI for @c FIRAuthUI.

FirebaseUI/Auth/AuthUI/Source/FIRAuthUI.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ - (nullable instancetype)initWithAuth:(FIRAuth *)auth {
7777
- (BOOL)handleOpenURL:(NSURL *)URL
7878
sourceApplication:(NSString *)sourceApplication {
7979
// Complete IDP-based sign-in flow.
80-
for (id<FIRAuthProviderUI> provider in _signInProviders) {
80+
for (id<FIRAuthProviderUI> provider in _providers) {
8181
if ([provider handleOpenURL:URL sourceApplication:sourceApplication]) {
8282
return YES;
8383
}

FirebaseUI/Auth/AuthUI/Source/FIRAuthUIUtils.h

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -33,12 +33,4 @@
3333
*/
3434
+ (UIImage *)imageNamed:(NSString *)name;
3535

36-
/** @fn URLWithString:query:
37-
@brief Constructs an URL from a string and additional query parameters.
38-
@param baseString The URL string to start with.
39-
@param queryParameters The dictionary of additional query parameters.
40-
@return The constructed URL.
41-
*/
42-
+ (NSURL *)URLWithString:(NSString *)urlString queryParameters:(NSDictionary *)queryParameters;
43-
4436
@end

FirebaseUI/Auth/AuthUI/Source/FIRAuthUIUtils.m

Lines changed: 0 additions & 58 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@
1616

1717
#import "FIRAuthUIUtils.h"
1818

19-
#import <CoreText/CoreText.h>
20-
2119
@implementation FIRAuthUIUtils
2220

2321
+ (NSBundle *)frameworkBundle {
@@ -40,60 +38,4 @@ + (UIImage *)imageNamed:(NSString *)name {
4038
return [UIImage imageWithContentsOfFile:path];
4139
}
4240

43-
+ (NSURL *)URLWithString:(NSString *)urlString queryParameters:(NSDictionary *)queryParameters {
44-
if ([urlString length] == 0) return nil;
45-
46-
NSString *fullURLString;
47-
if ([queryParameters count] > 0) {
48-
NSMutableArray *queryItems = [NSMutableArray arrayWithCapacity:[queryParameters count]];
49-
50-
// sort the custom parameter keys so that we have deterministic parameter
51-
// order for unit tests
52-
NSArray *queryKeys = [queryParameters allKeys];
53-
NSArray *sortedQueryKeys =
54-
[queryKeys sortedArrayUsingSelector:@selector(caseInsensitiveCompare:)];
55-
56-
for (NSString *paramKey in sortedQueryKeys) {
57-
NSString *paramValue = [queryParameters valueForKey:paramKey];
58-
59-
NSString *paramItem = [NSString stringWithFormat:@"%@=%@",
60-
[self stringByURLEncodingStringParameter:paramKey],
61-
[self stringByURLEncodingStringParameter:paramValue]];
62-
63-
[queryItems addObject:paramItem];
64-
}
65-
66-
NSString *paramStr = [queryItems componentsJoinedByString:@"&"];
67-
68-
BOOL hasQMark = ([urlString rangeOfString:@"?"].location == NSNotFound);
69-
char joiner = hasQMark ? '?' : '&';
70-
fullURLString = [NSString stringWithFormat:@"%@%c%@",
71-
urlString, joiner, paramStr];
72-
} else {
73-
fullURLString = urlString;
74-
}
75-
NSURL *result = [NSURL URLWithString:fullURLString];
76-
return result;
77-
}
78-
79-
+ (NSString *)stringByURLEncodingStringParameter:(NSString *)originalString {
80-
// For parameters, we'll explicitly leave spaces unescaped now, and replace
81-
// them with +'s
82-
NSString *const kForceEscape = @"!*'();:@&=+$,/?%#[]";
83-
NSString *const kLeaveUnescaped = @" ";
84-
85-
NSMutableCharacterSet *cs = [[NSCharacterSet URLQueryAllowedCharacterSet] mutableCopy];
86-
[cs removeCharactersInString:kForceEscape];
87-
[cs addCharactersInString:kLeaveUnescaped];
88-
89-
NSString *escapedStr = [originalString stringByAddingPercentEncodingWithAllowedCharacters:cs];
90-
NSString *resultStr = originalString;
91-
if (escapedStr) {
92-
// replace spaces with plusses
93-
resultStr = [escapedStr stringByReplacingOccurrencesOfString:@" "
94-
withString:@"+"];
95-
}
96-
return resultStr;
97-
}
98-
9941
@end

FirebaseUI/Auth/AuthUI/Source/FIREmailEntryViewController.m

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -176,9 +176,9 @@ - (UITableViewCell *)tableView:(UITableView *)tableView
176176
}
177177

178178
- (nullable id<FIRAuthProviderUI>)bestProviderFromProviderIDs:(NSArray<NSString *> *)providerIDs {
179-
NSArray<id<FIRAuthProviderUI>> *signInProviders = self.authUI.signInProviders;
179+
NSArray<id<FIRAuthProviderUI>> *providers = self.authUI.providers;
180180
for (NSString *providerID in providerIDs) {
181-
for (id<FIRAuthProviderUI> provider in signInProviders) {
181+
for (id<FIRAuthProviderUI> provider in providers) {
182182
if ([providerID isEqual:provider.providerID]) {
183183
return provider;
184184
}

FirebaseUI/Auth/AuthUI/Source/FIRPasswordSignUpViewController.m

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ - (void)viewDidLoad {
110110
- (void)viewDidLayoutSubviews {
111111
[super viewDidLayoutSubviews];
112112

113-
NSURL *termsOfServiceURL = self.authUI.termsOfServiceURL;
113+
NSURL *termsOfServiceURL = self.authUI.TOSURL;
114114
if (!termsOfServiceURL) {
115115
self.footerTextView.text = nil;
116116
return;
@@ -124,7 +124,7 @@ - (void)viewDidLayoutSubviews {
124124
[[NSMutableAttributedString alloc] initWithString:termsOfServiceNotice];
125125
NSRange termsOfServiceRange = [termsOfServiceNotice rangeOfString:termsOfService];
126126
[attributedString addAttribute:NSLinkAttributeName
127-
value:self.authUI.termsOfServiceURL.absoluteString
127+
value:self.authUI.TOSURL.absoluteString
128128
range:termsOfServiceRange];
129129
self.footerTextView.attributedText = attributedString;
130130

0 commit comments

Comments
 (0)