Skip to content

Commit 8b847a9

Browse files
Granfallonermorganchen12
authored andcommitted
Fixed dismissal/completion handling in email sign in controller. Corrected description.
1 parent 5f9cd91 commit 8b847a9

File tree

2 files changed

+5
-7
lines changed

2 files changed

+5
-7
lines changed

EmailAuth/FirebaseEmailAuthUI/FUIPasswordSignInViewController.m

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -168,10 +168,10 @@ - (void)signInWithDefaultValue:(NSString *)email andPassword:(NSString *)passwor
168168
return;
169169
}
170170
}
171-
[self.navigationController dismissViewControllerAnimated:YES completion:^{
172-
if (self->_onDismissCallback) {
173-
self->_onDismissCallback(authResult, error);
174-
}
171+
[self dismissNavigationControllerAnimated:true completion:^{
172+
if (self->_onDismissCallback) {
173+
self->_onDismissCallback(authResult, error);
174+
}
175175
}];
176176
};
177177

EmailAuth/FirebaseEmailAuthUI/FUIPasswordSignInViewController_Internal.h

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,7 @@ NS_ASSUME_NONNULL_BEGIN
2222
@interface FUIPasswordSignInViewController ()
2323

2424
/** @property onDismissCallback:
25-
@brief Sets an optional custom callback for FUIPasswordSigInViewController during dismissal. If
26-
this property is set the default dismissal routine is not triggered and should be included
27-
in this block if necessary. This block is NOT set to nil after use, set to nil after using
25+
@brief Sets an optional custom callback for FUIPasswordSigInViewController during dismissal. This block is NOT set to nil after use, set to nil after using
2826
if you wish to avoid circular references.
2927
*/
3028
@property(nonatomic, strong, nullable) FIRAuthDataResultCallback onDismissCallback;

0 commit comments

Comments
 (0)