Skip to content

Commit c14185f

Browse files
authored
Merge pull request #475 from morganchen12/master
Fix issue where FUIAuthPickerViewController always used default authUI for TOS/PP
2 parents c394949 + 81af661 commit c14185f

File tree

5 files changed

+312
-44
lines changed

5 files changed

+312
-44
lines changed

.travis.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
osx_image: xcode9.3
1+
osx_image: xcode9.4
22
language: objective-c
33
xcode_workspace: FirebaseUI.xcworkspace
44
xcode_scheme: FirebaseUI

FirebaseAuthUI/FUIAuthPickerViewController.m

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -140,12 +140,12 @@ - (void)viewDidLoad {
140140
}
141141

142142
- (NSAttributedString *)privacyPolicyAndTOS {
143-
if (![FUIAuth defaultAuthUI].TOSURL.absoluteString.length &&
144-
![FUIAuth defaultAuthUI].privacyPolicyURL.absoluteString.length) {
143+
if (!self.authUI.TOSURL.absoluteString.length &&
144+
!self.authUI.privacyPolicyURL.absoluteString.length) {
145145
return nil;
146146
}
147-
if (![FUIAuth defaultAuthUI].TOSURL.absoluteString.length ||
148-
![FUIAuth defaultAuthUI].privacyPolicyURL.absoluteString.length) {
147+
if (!self.authUI.TOSURL.absoluteString.length ||
148+
!self.authUI.privacyPolicyURL.absoluteString.length) {
149149
NSLog(@"The terms of service and privacy policy URLs for your app must be provided together. Pl"
150150
"ease set the terms of service policy using [FUIAuth defaultAuthUI].TOSURL and the privacy"
151151
" policy URL using [FUIAuth defaultAuthUI].privacyPolicyURL");
@@ -162,15 +162,15 @@ - (NSAttributedString *)privacyPolicyAndTOS {
162162

163163
if (TOSRange.length) {
164164
[attributedLinkText addAttribute:NSLinkAttributeName
165-
value:[FUIAuth defaultAuthUI].TOSURL
165+
value:self.authUI.TOSURL
166166
range:TOSRange];
167167
}
168168
NSRange privacyPolicyRange =
169169
[privacyPolicyAndTOSString rangeOfString:FUILocalizedString(kStr_PrivacyPolicy)];
170170

171171
if (privacyPolicyRange.length) {
172172
[attributedLinkText addAttribute:NSLinkAttributeName
173-
value:[FUIAuth defaultAuthUI].privacyPolicyURL
173+
value:self.authUI.privacyPolicyURL
174174
range:privacyPolicyRange];
175175
}
176176
return attributedLinkText;

0 commit comments

Comments
 (0)