Skip to content

Commit c4df596

Browse files
authored
Merge pull request #126 from morganchen12/builds
continue to build static targets for now
2 parents 4ff8237 + bfb6316 commit c4df596

File tree

11 files changed

+572
-60
lines changed

11 files changed

+572
-60
lines changed

FirebaseAuthUI/FIRAuthPickerViewController.xib

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
2-
<document type="com.apple.InterfaceBuilder3.CocoaTouch.XIB" version="3.0" toolsVersion="10117" systemVersion="15G31" targetRuntime="iOS.CocoaTouch" propertyAccessControl="none" useAutolayout="YES" useTraitCollections="YES">
2+
<document type="com.apple.InterfaceBuilder3.CocoaTouch.XIB" version="3.0" toolsVersion="10117" systemVersion="15G1004" targetRuntime="iOS.CocoaTouch" propertyAccessControl="none" useAutolayout="YES" useTraitCollections="YES">
33
<dependencies>
44
<deployment identifier="iOS"/>
55
<plugIn identifier="com.apple.InterfaceBuilder.IBCocoaTouchPlugin" version="10085"/>

FirebaseAuthUI/FirebaseAuthUI.h

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,9 @@ FOUNDATION_EXPORT double FirebaseAuthUIVersionNumber;
2222
//! Project version string for FirebaseAuthUI.
2323
FOUNDATION_EXPORT const unsigned char FirebaseAuthUIVersionString[];
2424

25-
#import <FIRAuthPickerViewController.h>
26-
#import <FIRAuthProviderUI.h>
27-
#import <FIRAuthUI.h>
28-
#import <FIRAuthUIBaseViewController.h>
29-
#import <FIRAuthUIErrorUtils.h>
25+
#import <FirebaseAuthUI/FIRAuthPickerViewController.h>
26+
#import <FirebaseAuthUI/FIRAuthProviderUI.h>
27+
#import <FirebaseAuthUI/FIRAuthUI.h>
28+
#import <FirebaseAuthUI/FIRAuthUIBaseViewController.h>
29+
#import <FirebaseAuthUI/FIRAuthUIErrorUtils.h>
3030

FirebaseFacebookAuthUI/FIRFacebookAuthUI.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
// limitations under the License.
1515
//
1616

17-
#import <FIRAuthUI.h>
17+
#import <FirebaseAuthUI/FIRAuthUI.h>
1818

1919
NS_ASSUME_NONNULL_BEGIN
2020

FirebaseFacebookAuthUI/FIRFacebookAuthUI.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
#import <FirebaseAuth/FIRUserInfo.h>
2121
#import <FBSDKCoreKit/FBSDKCoreKit.h>
2222
#import <FBSDKLoginKit/FBSDKLoginKit.h>
23-
#import <FIRAuthUIErrorUtils.h>
23+
#import <FirebaseAuthUI/FIRAuthUIErrorUtils.h>
2424

2525
/** @var kBundleFileName
2626
@brief The name of the bundle containing Facebook auth provider assets/resources.

FirebaseGoogleAuthUI/FIRGoogleAuthUI.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
// limitations under the License.
1515
//
1616

17-
#import <FIRAuthUI.h>
17+
#import <FirebaseAuthUI/FIRAuthUI.h>
1818

1919
NS_ASSUME_NONNULL_BEGIN
2020

FirebaseGoogleAuthUI/FIRGoogleAuthUI.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
#import <GoogleSignIn/GoogleSignIn.h>
2020
#import <FirebaseAuth/FIRGoogleAuthProvider.h>
2121
#import <FirebaseAuth/FIRUserInfo.h>
22-
#import <FIRAuthUIErrorUtils.h>
22+
#import <FirebaseAuthUI/FIRAuthUIErrorUtils.h>
2323

2424
/** @var kGoogleGamesScope
2525
@brief The OAuth scope string for the "Games" scope.

FirebaseUI.podspec

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
Pod::Spec.new do |s|
22
s.name = 'FirebaseUI'
3-
s.version = '0.5.3'
3+
s.version = '0.5.4'
44
s.summary = 'UI binding libraries for Firebase.'
55
s.homepage = 'https://github.com/firebase/FirebaseUI-iOS'
66
s.license = { :type => 'Apache 2.0', :file => 'FirebaseUIFrameworks/LICENSE' }
77
s.author = 'Firebase'
8-
s.source = { :http => 'https://github.com/firebase/FirebaseUI-iOS/releases/download/0.5.3/FirebaseUIFrameworks.zip' }
8+
s.source = { :http => 'https://github.com/firebase/FirebaseUI-iOS/releases/download/0.5.4/FirebaseUIFrameworks.zip' }
99
s.platform = :ios
10-
s.ios.deployment_target = '8.0'
10+
s.ios.deployment_target = '7.0'
1111
s.ios.framework = 'UIKit'
1212
s.requires_arc = true
1313
s.default_subspecs = 'All'

FirebaseUI.xcodeproj/project.pbxproj

Lines changed: 499 additions & 2 deletions
Large diffs are not rendered by default.

Podfile

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,3 +51,24 @@ target 'FirebaseGoogleAuthUI' do
5151
end
5252
end
5353

54+
target 'Database' do
55+
# Pods for Database
56+
pod 'Firebase/Database'
57+
end
58+
59+
target 'Auth' do
60+
# Pods for Auth
61+
pod 'Firebase/Auth'
62+
end
63+
64+
target 'Facebook' do
65+
# Pods for Facebook Auth
66+
pod 'Firebase/Auth'
67+
pod 'FBSDKLoginKit', '~> 4.0'
68+
end
69+
70+
target 'Google' do
71+
# Pods for Google Auth
72+
pod 'Firebase/Auth'
73+
pod 'GoogleSignIn', '~> 4.0'
74+
end

build.swift

Lines changed: 31 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,13 @@ let schemes = [
102102
"FirebaseGoogleAuthUI",
103103
]
104104

105+
let staticLibs = [
106+
"Database": "FirebaseDatabaseUI",
107+
"Auth" : "FirebaseAuthUI",
108+
"Facebook": "FirebaseFacebookAuthUI",
109+
"Google" : "FirebaseGoogleAuthUI",
110+
]
111+
105112
// make folder structure for built products
106113
schemes.forEach { scheme in
107114
let schemeDir = BuiltProductsDir + scheme
@@ -110,9 +117,23 @@ schemes.forEach { scheme in
110117
}
111118

112119
// Invoke xcodebuild, building each scheme in
113-
// release for each target sdk
114-
let builds = sdks.flatMap { sdk in
115-
return schemes.map { scheme in
120+
// release for each target sdk. Building
121+
// dynamic frameworks so we don't have to do
122+
// the asset bundling and folder structures manually,
123+
// at the costs of lots of duplication. Not sure if ideal.
124+
let builds = schemes.map { scheme in
125+
return Build([
126+
"-workspace" : "FirebaseUI.xcworkspace",
127+
"-scheme" : scheme,
128+
"-configuration" : "Release",
129+
"-sdk" : sdks[0],
130+
"-derivedDataPath": DerivedDataDir,
131+
])
132+
}
133+
134+
let staticBuilds: [Build] = sdks.flatMap { sdk -> [Build] in
135+
let schemeNames = Array(staticLibs.keys)
136+
return schemeNames.map { scheme -> Build in
116137
return Build([
117138
"-workspace" : "FirebaseUI.xcworkspace",
118139
"-scheme" : scheme,
@@ -124,6 +145,7 @@ let builds = sdks.flatMap { sdk in
124145
}
125146

126147
builds.forEach { $0.launch() }
148+
staticBuilds.forEach { $0.launch() }
127149

128150
// Copy frameworks into built products dir. Don't really
129151
// care about sdk here since we're gonna lipo everything later
@@ -161,16 +183,16 @@ let productsPaths = sdks.map {
161183
}
162184

163185
// create lipo tasks from built products
164-
let lipos: [Lipo] = schemes.map { scheme in
165-
let framework = "\(scheme).framework"
166-
let binary = scheme
186+
let lipos: [Lipo] = Array(staticLibs.keys).map { scheme in
187+
let product = staticLibs[scheme]!
188+
let framework = "\(product).framework"
189+
let binary = "lib\(scheme).a"
167190

168-
let lib = "\(scheme).framework/\(scheme)"
169191
let chunks = productsPaths.map { path in
170-
return path + lib
192+
return path + binary
171193
}
172194

173-
let output = "\(BuiltProductsDir)\(scheme)/Frameworks/\(framework)/\(binary)"
195+
let output = "\(BuiltProductsDir)\(product)/Frameworks/\(framework)/\(product)"
174196
return Lipo(inputs: chunks, output: output)
175197
}
176198

samples/swift/uidemo.xcodeproj/project.pbxproj

Lines changed: 8 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@
77
objects = {
88

99
/* Begin PBXBuildFile section */
10-
433E703692A371C84E532086 /* Pods_uidemoTests.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 45B7A43C757A128633BBDAFF /* Pods_uidemoTests.framework */; };
11-
6001626D469756A781BC0C1D /* Pods_uidemo.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = C0B23F4C2DB9A671802E1E31 /* Pods_uidemo.framework */; };
1210
8D16073E1D492B200069E4F5 /* AuthViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 8D16073D1D492B200069E4F5 /* AuthViewController.swift */; };
1311
8DABC9891D3D82D600453807 /* AppDelegate.swift in Sources */ = {isa = PBXBuildFile; fileRef = 8DABC9881D3D82D600453807 /* AppDelegate.swift */; };
1412
8DABC98B1D3D82D600453807 /* MenuViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 8DABC98A1D3D82D600453807 /* MenuViewController.swift */; };
@@ -19,6 +17,7 @@
1917
8DABC9A91D3D872C00453807 /* Sample.swift in Sources */ = {isa = PBXBuildFile; fileRef = 8DABC9A81D3D872C00453807 /* Sample.swift */; };
2018
8DABC9AB1D3D947300453807 /* SampleCell.swift in Sources */ = {isa = PBXBuildFile; fileRef = 8DABC9AA1D3D947300453807 /* SampleCell.swift */; };
2119
8DABC9AD1D3D9EAF00453807 /* ChatViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 8DABC9AC1D3D9EAF00453807 /* ChatViewController.swift */; };
20+
8DD51E371D873B0D00E2CA51 /* UIStoryboardExtension.swift in Sources */ = {isa = PBXBuildFile; fileRef = 8DD51E361D873B0D00E2CA51 /* UIStoryboardExtension.swift */; };
2221
8DDF1AE51D3FF67D001F1160 /* ChatCollectionViewCell.swift in Sources */ = {isa = PBXBuildFile; fileRef = 8DDF1AE41D3FF67D001F1160 /* ChatCollectionViewCell.swift */; };
2322
C3F23ECD1D80F3300020509F /* GoogleService-Info.plist in Resources */ = {isa = PBXBuildFile; fileRef = C3F23ECC1D80F3300020509F /* GoogleService-Info.plist */; };
2423
/* End PBXBuildFile section */
@@ -34,10 +33,6 @@
3433
/* End PBXContainerItemProxy section */
3534

3635
/* Begin PBXFileReference section */
37-
45B7A43C757A128633BBDAFF /* Pods_uidemoTests.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; includeInIndex = 0; path = Pods_uidemoTests.framework; sourceTree = BUILT_PRODUCTS_DIR; };
38-
4C4F100F73AB7282D3071228 /* Pods-uidemo.release.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-uidemo.release.xcconfig"; path = "Pods/Target Support Files/Pods-uidemo/Pods-uidemo.release.xcconfig"; sourceTree = "<group>"; };
39-
74B1CFAE0F3BD0D456DFCC76 /* Pods-uidemoTests.debug.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-uidemoTests.debug.xcconfig"; path = "Pods/Target Support Files/Pods-uidemoTests/Pods-uidemoTests.debug.xcconfig"; sourceTree = "<group>"; };
40-
8C5E1A3D7FD94BB28A092EBC /* Pods-uidemoTests.release.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-uidemoTests.release.xcconfig"; path = "Pods/Target Support Files/Pods-uidemoTests/Pods-uidemoTests.release.xcconfig"; sourceTree = "<group>"; };
4136
8D16073D1D492B200069E4F5 /* AuthViewController.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = AuthViewController.swift; sourceTree = "<group>"; };
4237
8DABC9851D3D82D600453807 /* uidemo.app */ = {isa = PBXFileReference; explicitFileType = wrapper.application; includeInIndex = 0; path = uidemo.app; sourceTree = BUILT_PRODUCTS_DIR; };
4338
8DABC9881D3D82D600453807 /* AppDelegate.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = AppDelegate.swift; sourceTree = "<group>"; };
@@ -52,26 +47,23 @@
5247
8DABC9A81D3D872C00453807 /* Sample.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = Sample.swift; sourceTree = "<group>"; };
5348
8DABC9AA1D3D947300453807 /* SampleCell.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = SampleCell.swift; sourceTree = "<group>"; };
5449
8DABC9AC1D3D9EAF00453807 /* ChatViewController.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = ChatViewController.swift; sourceTree = "<group>"; };
50+
8DD51E361D873B0D00E2CA51 /* UIStoryboardExtension.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = UIStoryboardExtension.swift; sourceTree = "<group>"; };
5551
8DDF1AE41D3FF67D001F1160 /* ChatCollectionViewCell.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = ChatCollectionViewCell.swift; sourceTree = "<group>"; };
56-
C0B23F4C2DB9A671802E1E31 /* Pods_uidemo.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; includeInIndex = 0; path = Pods_uidemo.framework; sourceTree = BUILT_PRODUCTS_DIR; };
5752
C3F23ECC1D80F3300020509F /* GoogleService-Info.plist */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.plist.xml; path = "GoogleService-Info.plist"; sourceTree = "<group>"; };
58-
CB9DA206245B6BEB7500A66A /* Pods-uidemo.debug.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-uidemo.debug.xcconfig"; path = "Pods/Target Support Files/Pods-uidemo/Pods-uidemo.debug.xcconfig"; sourceTree = "<group>"; };
5953
/* End PBXFileReference section */
6054

6155
/* Begin PBXFrameworksBuildPhase section */
6256
8DABC9821D3D82D600453807 /* Frameworks */ = {
6357
isa = PBXFrameworksBuildPhase;
6458
buildActionMask = 2147483647;
6559
files = (
66-
6001626D469756A781BC0C1D /* Pods_uidemo.framework in Frameworks */,
6760
);
6861
runOnlyForDeploymentPostprocessing = 0;
6962
};
7063
8DABC9961D3D82D600453807 /* Frameworks */ = {
7164
isa = PBXFrameworksBuildPhase;
7265
buildActionMask = 2147483647;
7366
files = (
74-
433E703692A371C84E532086 /* Pods_uidemoTests.framework in Frameworks */,
7567
);
7668
runOnlyForDeploymentPostprocessing = 0;
7769
};
@@ -94,8 +86,6 @@
9486
8DABC9871D3D82D600453807 /* uidemo */,
9587
8DABC99C1D3D82D600453807 /* uidemoTests */,
9688
8DABC9861D3D82D600453807 /* Products */,
97-
94250E737FC3C4C5C6F2681A /* Pods */,
98-
F6DBA04B6C438DF62F38F922 /* Frameworks */,
9989
);
10090
sourceTree = "<group>";
10191
};
@@ -115,6 +105,7 @@
115105
8DABC98A1D3D82D600453807 /* MenuViewController.swift */,
116106
8DABC9AA1D3D947300453807 /* SampleCell.swift */,
117107
8DABC9A81D3D872C00453807 /* Sample.swift */,
108+
8DD51E361D873B0D00E2CA51 /* UIStoryboardExtension.swift */,
118109
8DD17C951D4BCC6500E850E4 /* AuthSample */,
119110
8D643F0F1D4827F10081F979 /* ChatSample */,
120111
8DABC98C1D3D82D600453807 /* Main.storyboard */,
@@ -142,26 +133,6 @@
142133
name = AuthSample;
143134
sourceTree = "<group>";
144135
};
145-
94250E737FC3C4C5C6F2681A /* Pods */ = {
146-
isa = PBXGroup;
147-
children = (
148-
CB9DA206245B6BEB7500A66A /* Pods-uidemo.debug.xcconfig */,
149-
4C4F100F73AB7282D3071228 /* Pods-uidemo.release.xcconfig */,
150-
74B1CFAE0F3BD0D456DFCC76 /* Pods-uidemoTests.debug.xcconfig */,
151-
8C5E1A3D7FD94BB28A092EBC /* Pods-uidemoTests.release.xcconfig */,
152-
);
153-
name = Pods;
154-
sourceTree = "<group>";
155-
};
156-
F6DBA04B6C438DF62F38F922 /* Frameworks */ = {
157-
isa = PBXGroup;
158-
children = (
159-
C0B23F4C2DB9A671802E1E31 /* Pods_uidemo.framework */,
160-
45B7A43C757A128633BBDAFF /* Pods_uidemoTests.framework */,
161-
);
162-
name = Frameworks;
163-
sourceTree = "<group>";
164-
};
165136
/* End PBXGroup section */
166137

167138
/* Begin PBXNativeTarget section */
@@ -365,6 +336,7 @@
365336
files = (
366337
8DABC98B1D3D82D600453807 /* MenuViewController.swift in Sources */,
367338
8DABC9AB1D3D947300453807 /* SampleCell.swift in Sources */,
339+
8DD51E371D873B0D00E2CA51 /* UIStoryboardExtension.swift in Sources */,
368340
8DABC9A91D3D872C00453807 /* Sample.swift in Sources */,
369341
8D16073E1D492B200069E4F5 /* AuthViewController.swift in Sources */,
370342
8DABC9AD1D3D9EAF00453807 /* ChatViewController.swift in Sources */,
@@ -415,6 +387,7 @@
415387
isa = XCBuildConfiguration;
416388
buildSettings = {
417389
ALWAYS_SEARCH_USER_PATHS = NO;
390+
BITCODE_GENERATION_MODE = bitcode;
418391
CLANG_ANALYZER_NONNULL = YES;
419392
CLANG_CXX_LANGUAGE_STANDARD = "gnu++0x";
420393
CLANG_CXX_LIBRARY = "libc++";
@@ -461,6 +434,7 @@
461434
isa = XCBuildConfiguration;
462435
buildSettings = {
463436
ALWAYS_SEARCH_USER_PATHS = NO;
437+
BITCODE_GENERATION_MODE = bitcode;
464438
CLANG_ANALYZER_NONNULL = YES;
465439
CLANG_CXX_LANGUAGE_STANDARD = "gnu++0x";
466440
CLANG_CXX_LIBRARY = "libc++";
@@ -498,9 +472,9 @@
498472
};
499473
8DABC9A31D3D82D600453807 /* Debug */ = {
500474
isa = XCBuildConfiguration;
501-
baseConfigurationReference = CB9DA206245B6BEB7500A66A /* Pods-uidemo.debug.xcconfig */;
502475
buildSettings = {
503476
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
477+
BITCODE_GENERATION_MODE = "";
504478
CLANG_ENABLE_MODULES = YES;
505479
INFOPLIST_FILE = uidemo/Info.plist;
506480
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
@@ -513,9 +487,9 @@
513487
};
514488
8DABC9A41D3D82D600453807 /* Release */ = {
515489
isa = XCBuildConfiguration;
516-
baseConfigurationReference = 4C4F100F73AB7282D3071228 /* Pods-uidemo.release.xcconfig */;
517490
buildSettings = {
518491
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
492+
BITCODE_GENERATION_MODE = "";
519493
CLANG_ENABLE_MODULES = YES;
520494
INFOPLIST_FILE = uidemo/Info.plist;
521495
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
@@ -527,7 +501,6 @@
527501
};
528502
8DABC9A61D3D82D600453807 /* Debug */ = {
529503
isa = XCBuildConfiguration;
530-
baseConfigurationReference = 74B1CFAE0F3BD0D456DFCC76 /* Pods-uidemoTests.debug.xcconfig */;
531504
buildSettings = {
532505
BUNDLE_LOADER = "$(TEST_HOST)";
533506
INFOPLIST_FILE = uidemoTests/Info.plist;
@@ -540,7 +513,6 @@
540513
};
541514
8DABC9A71D3D82D600453807 /* Release */ = {
542515
isa = XCBuildConfiguration;
543-
baseConfigurationReference = 8C5E1A3D7FD94BB28A092EBC /* Pods-uidemoTests.release.xcconfig */;
544516
buildSettings = {
545517
BUNDLE_LOADER = "$(TEST_HOST)";
546518
INFOPLIST_FILE = uidemoTests/Info.plist;

0 commit comments

Comments
 (0)