Merge pull request #682 from xuaninbox/master

Revert "Don't use password autofill if Performance is linked"

Author: morganchen12

Auth/FirebaseAuthUI/FUIAuthUtils.h

@@ -49,9 +49,4 @@ extern NSString *const FUIAuthBundleName;
  */
 + (UIImage *)imageNamed:(NSString *)name fromBundle:(nullable NSBundle *)bundle;
 
-/** @fn isFirebasePerformanceAvailable
- * @brief Used to work around https://github.com/firebase/firebase-ios-sdk/issues/2283
- */
-+ (BOOL)isFirebasePerformanceAvailable;
-
 @end

Auth/FirebaseAuthUI/FUIAuthUtils.m

@@ -56,8 +56,4 @@ + (UIImage *)imageNamed:(NSString *)name fromBundleNameOrNil:(nullable NSString
   return [UIImage imageWithContentsOfFile:path];
 }
 
-+ (BOOL)isFirebasePerformanceAvailable {
-  return NSClassFromString(@"FIRPerformance") != nil;
-}
-
 @end

EmailAuth/FirebaseEmailAuthUI/FUIEmailEntryViewController.m

@@ -291,9 +291,7 @@ - (UITableViewCell *)tableView:(UITableView *)tableView
   cell.textField.returnKeyType = UIReturnKeyNext;
   cell.textField.keyboardType = UIKeyboardTypeEmailAddress;
   if (@available(iOS 11.0, *)) {
-    if (![FUIAuthUtils isFirebasePerformanceAvailable]) {
-      cell.textField.textContentType = UITextContentTypeUsername;
-    }
+    cell.textField.textContentType = UITextContentTypeUsername; 
   }
   [cell.textField addTarget:self
                      action:@selector(textFieldDidChange)

EmailAuth/FirebaseEmailAuthUI/FUIPasswordRecoveryViewController.m

@@ -182,9 +182,7 @@ - (UITableViewCell *)tableView:(UITableView *)tableView
   _emailField.autocorrectionType = UITextAutocorrectionTypeNo;
   _emailField.autocapitalizationType = UITextAutocapitalizationTypeNone;
   if (@available(iOS 11.0, *)) {
-    if (![FUIAuthUtils isFirebasePerformanceAvailable]) {
-      _emailField.textContentType = UITextContentTypeUsername;
-    }
+    _emailField.textContentType = UITextContentTypeUsername;
   }
   [cell.textField addTarget:self
                      action:@selector(textFieldDidChange)

EmailAuth/FirebaseEmailAuthUI/FUIPasswordSignInViewController.m

@@ -258,9 +258,7 @@ - (UITableViewCell *)tableView:(UITableView *)tableView
     _emailField.autocorrectionType = UITextAutocorrectionTypeNo;
     _emailField.autocapitalizationType = UITextAutocapitalizationTypeNone;
     if (@available(iOS 11.0, *)) {
-      if (![FUIAuthUtils isFirebasePerformanceAvailable]) {
-        _emailField.textContentType = UITextContentTypeUsername;
-      }
+      _emailField.textContentType = UITextContentTypeUsername;
     }
   } else if (indexPath.row == 1) {
     cell.label.text = FUILocalizedString(kStr_Password);
@@ -270,9 +268,7 @@ - (UITableViewCell *)tableView:(UITableView *)tableView
     _passwordField.returnKeyType = UIReturnKeyNext;
     _passwordField.keyboardType = UIKeyboardTypeDefault;
     if (@available(iOS 11.0, *)) {
-      if (![FUIAuthUtils isFirebasePerformanceAvailable]) {
-        _passwordField.textContentType = UITextContentTypePassword;
-      }
+      _passwordField.textContentType = UITextContentTypePassword;
     }
   }
   [cell.textField addTarget:self

EmailAuth/FirebaseEmailAuthUI/FUIPasswordSignUpViewController.m

@@ -268,9 +268,7 @@ - (UITableViewCell *)tableView:(UITableView *)tableView
     _emailField.autocorrectionType = UITextAutocorrectionTypeNo;
     _emailField.autocapitalizationType = UITextAutocapitalizationTypeNone;
     if (@available(iOS 11.0, *)) {
-      if (![FUIAuthUtils isFirebasePerformanceAvailable]) {
-        _emailField.textContentType = UITextContentTypeUsername;
-      }
+      _emailField.textContentType = UITextContentTypeUsername;
     }
   } else if (indexPath.row == 1) {
     cell.label.text = FUILocalizedString(kStr_Name);
@@ -294,9 +292,7 @@ - (UITableViewCell *)tableView:(UITableView *)tableView
     _passwordField.returnKeyType = UIReturnKeyNext;
     _passwordField.keyboardType = UIKeyboardTypeDefault;
     if (@available(iOS 11.0, *)) {
-      if (![FUIAuthUtils isFirebasePerformanceAvailable]) {
-        _passwordField.textContentType = UITextContentTypePassword;
-      }
+      _passwordField.textContentType = UITextContentTypePassword;
     }
   }
   [cell.textField addTarget:self

EmailAuth/FirebaseEmailAuthUI/FUIPasswordVerificationViewController.m

@@ -222,9 +222,7 @@ - (UITableViewCell *)tableView:(UITableView *)tableView
   _passwordField.returnKeyType = UIReturnKeyNext;
   _passwordField.keyboardType = UIKeyboardTypeDefault;
   if (@available(iOS 11.0, *)) {
-    if (![FUIAuthUtils isFirebasePerformanceAvailable]) {
-      _passwordField.textContentType = UITextContentTypePassword;
-    }
+    _passwordField.textContentType = UITextContentTypePassword;
   }
   [cell.textField addTarget:self
                      action:@selector(textFieldDidChange)