Skip to content

Code sanitization #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 7, 2018
Merged

Code sanitization #417

merged 2 commits into from
Mar 7, 2018

Conversation

protocol86
Copy link
Contributor

  • Aligns colons
  • Removes unnecessary nil check
  • documents internal method
  • Fixes minor typos

@protocol86
Code sanitization
0afd096 
- Aligns colons
- Removes uncessary nil check
- documents internal method
- Fixes minor typos
@protocol86 protocol86 requested a review from morganchen12 March 7, 2018 20:05
morganchen12
morganchen12 approved these changes Mar 7, 2018
View reviewed changes
Copy link
Contributor

@morganchen12 morganchen12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one nit

FirebaseAuthUI/FUIAuth.m Outdated
@@ -208,10 +208,20 @@ - (void)signInWithProviderUI:(id<FUIAuthProvider>)providerUI
}];
}

/** @fn handleAccountLinkingForEmail:newCredential:presentingViewController:singInResult
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

signInResult typo at the end of the line

@protocol86 protocol86 merged commit d614ad4 into master Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morganchen12 morganchen12 morganchen12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@protocol86 @morganchen12