PR fixes

Author: lahirumaramba

src/main/java/com/google/firebase/remoteconfig/Condition.java

@@ -40,29 +40,24 @@ public final class Condition {
   /**
    * Creates a new {@link Condition}.
    *
-   * @param name       A non-null, non-empty, and unique name of this condition.
+   * @param name A non-null, non-empty, and unique name of this condition.
    * @param expression A non-null and non-empty expression of this condition.
    */
   public Condition(@NonNull String name, @NonNull String expression) {
-    checkArgument(!Strings.isNullOrEmpty(name), "condition name must not be null or empty");
-    checkArgument(!Strings.isNullOrEmpty(expression),
-            "condition expression must not be null or empty");
-    this.name = name;
-    this.expression = expression;
+    this(name, expression, null);
   }
 
   /**
    * Creates a new {@link Condition}.
    *
-   * @param name       A non-null, non-empty, and unique name of this condition.
+   * @param name A non-null, non-empty, and unique name of this condition.
    * @param expression A non-null and non-empty expression of this condition.
-   * @param tagColor   A non-null tag color of this condition.
+   * @param tagColor A tag color of this condition.
    */
-  public Condition(@NonNull String name, @NonNull String expression, @NonNull TagColor tagColor) {
+  public Condition(@NonNull String name, @NonNull String expression, @Nullable TagColor tagColor) {
     checkArgument(!Strings.isNullOrEmpty(name), "condition name must not be null or empty");
     checkArgument(!Strings.isNullOrEmpty(expression),
             "condition expression must not be null or empty");
-    checkNotNull(tagColor, "condition tag color must not be null");
     this.name = name;
     this.expression = expression;
     this.tagColor = tagColor;

src/test/java/com/google/firebase/remoteconfig/ConditionTest.java

@@ -0,0 +1,40 @@
+/*
+ * Copyright 2020 Google LLC
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.google.firebase.remoteconfig;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotEquals;
+
+import org.junit.Test;
+
+public class ConditionTest {
+
+  @Test
+  public void testEquality() {
+    Condition conditionOne = new Condition("ios", "device.os == 'ios'", TagColor.GREEN);
+    Condition conditionTwo = new Condition("ios", "device.os == 'ios'", TagColor.GREEN);
+    Condition conditionThree = new Condition("android", "device.os == 'android'");
+    Condition conditionFour = new Condition("android", "device.os == 'android'");
+    Condition conditionFive = new Condition("ios", "device.os == 'ios'", TagColor.BLUE);
+
+    assertEquals(conditionOne, conditionTwo);
+    assertEquals(conditionThree, conditionFour);
+    assertNotEquals(conditionOne, conditionThree);
+    assertNotEquals(conditionTwo, conditionFour);
+    assertNotEquals(conditionOne, conditionFive);
+  }
+}