ThenableReference should extend Promise, not PromiseLike #498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsayol
force-pushed
the
fix-thenablereference-type
branch
from
230c48b to
18608c7
Compare
ThenableReference implements a `.catch()` method, but `ref.push(...).catch(...)` generates a TypeScript error, since neither the `Reference` nor `PromiseLike` interfaces have that method. This change was [already done on the JS SDK](firebase/firebase-js-sdk#1462) back in January, and this PR simply puts the admin SDK back in line with it.
jsayol
force-pushed
the
fix-thenablereference-type
branch
from
18608c7 to
ae54aad
Compare
Feiyang1
approved these changes
Apr 24, 2019
schmidt-sebastian
approved these changes
Apr 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ThenableReference implements a
.catch()method, butref.push(...).catch(...)generates a TypeScript error, since neither theReferencenorPromiseLikeinterfaces have that method.This change was already done on the JS SDK back in January, and this PR simply puts the admin SDK back in line with it.
PS: This fixes issue #144, which was already closed.