Skip to content

Enable stricter tsconfig compilerOptions #674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2019

Conversation

rsgowman
Copy link
Member

Specifically, noImplicitThis, alwaysStrict, strictBindCallApply. No
changes to the source were required; we were already compliant with
these options.

@rsgowman rsgowman self-assigned this Oct 18, 2019
Specifically, noImplicitThis, alwaysStrict, strictBindCallApply. No
changes to the source were required; we were already compliant with
these options.
@rsgowman rsgowman force-pushed the rsgowman/tsconfig_stricter branch from 096b4d9 to e6f520a Compare October 21, 2019 13:51
@rsgowman rsgowman changed the base branch from rsgowman/test_ordering to master October 21, 2019 13:54
@rsgowman rsgowman assigned hiranya911 and unassigned rsgowman Oct 21, 2019
@rsgowman rsgowman requested a review from hiranya911 October 21, 2019 14:02
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hiranya911 hiranya911 assigned rsgowman and unassigned hiranya911 Oct 21, 2019
@rsgowman rsgowman merged commit 8678922 into master Oct 21, 2019
@rsgowman rsgowman deleted the rsgowman/tsconfig_stricter branch October 21, 2019 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants