Fix from API Review

Author: tom-andersen

firebase-firestore/api.txt

@@ -433,7 +433,6 @@ package com.google.firebase.firestore {
     method public com.google.firebase.firestore.Pipeline findNearest(String vectorField, com.google.firebase.firestore.VectorValue vectorValue, com.google.firebase.firestore.pipeline.FindNearestStage.DistanceMeasure distanceMeasure);
     method public com.google.firebase.firestore.Pipeline findNearest(String vectorField, double[] vectorValue, com.google.firebase.firestore.pipeline.FindNearestStage.DistanceMeasure distanceMeasure);
     method public com.google.firebase.firestore.Pipeline genericStage(com.google.firebase.firestore.pipeline.GenericStage stage);
-    method public com.google.firebase.firestore.Pipeline genericStage(String name, java.lang.Object... arguments);
     method public com.google.firebase.firestore.Pipeline limit(int limit);
     method public com.google.firebase.firestore.Pipeline offset(int offset);
     method public com.google.firebase.firestore.Pipeline removeFields(com.google.firebase.firestore.pipeline.Field field, com.google.firebase.firestore.pipeline.Field... additionalFields);
@@ -991,7 +990,7 @@ package com.google.firebase.firestore.pipeline {
     method public final com.google.firebase.firestore.pipeline.Expr floor();
     method public static final com.google.firebase.firestore.pipeline.Expr floor(com.google.firebase.firestore.pipeline.Expr numericExpr);
     method public static final com.google.firebase.firestore.pipeline.Expr floor(String numericField);
-    method public static final com.google.firebase.firestore.pipeline.FunctionExpr generic(String name, com.google.firebase.firestore.pipeline.Expr... expr);
+    method public static final com.google.firebase.firestore.pipeline.Expr generic(String name, com.google.firebase.firestore.pipeline.Expr... expr);
     method public final com.google.firebase.firestore.pipeline.BooleanExpr gt(com.google.firebase.firestore.pipeline.Expr other);
     method public static final com.google.firebase.firestore.pipeline.BooleanExpr gt(com.google.firebase.firestore.pipeline.Expr left, com.google.firebase.firestore.pipeline.Expr right);
     method public static final com.google.firebase.firestore.pipeline.BooleanExpr gt(com.google.firebase.firestore.pipeline.Expr left, Object right);
@@ -1324,7 +1323,7 @@ package com.google.firebase.firestore.pipeline {
     method public com.google.firebase.firestore.pipeline.Field field(String name);
     method public com.google.firebase.firestore.pipeline.Expr floor(com.google.firebase.firestore.pipeline.Expr numericExpr);
     method public com.google.firebase.firestore.pipeline.Expr floor(String numericField);
-    method public com.google.firebase.firestore.pipeline.FunctionExpr generic(String name, com.google.firebase.firestore.pipeline.Expr... expr);
+    method public com.google.firebase.firestore.pipeline.Expr generic(String name, com.google.firebase.firestore.pipeline.Expr... expr);
     method public com.google.firebase.firestore.pipeline.BooleanExpr gt(com.google.firebase.firestore.pipeline.Expr left, com.google.firebase.firestore.pipeline.Expr right);
     method public com.google.firebase.firestore.pipeline.BooleanExpr gt(com.google.firebase.firestore.pipeline.Expr left, Object right);
     method public com.google.firebase.firestore.pipeline.BooleanExpr gt(String fieldName, com.google.firebase.firestore.pipeline.Expr expression);

firebase-firestore/src/main/java/com/google/firebase/firestore/Pipeline.kt

@@ -102,23 +102,6 @@ internal constructor(
       .addAllStages(stages.map { it.toProtoStage(userDataReader) })
       .build()
 
-  /**
-   * Adds a stage to the pipeline by specifying the stage name as an argument. This does not offer
-   * any type safety on the stage params and requires the caller to know the order (and optionally
-   * names) of parameters accepted by the stage.
-   *
-   * This method provides a way to call stages that are supported by the Firestore backend but that
-   * are not implemented in the SDK version being used.
-   *
-   * For stages with named parameters, use the [GenericStage] class instead.
-   *
-   * @param name The unique name of the stage to add.
-   * @param arguments A list of ordered parameters to configure the stage's behavior.
-   * @return A new [Pipeline] object with this stage appended to the stage list.
-   */
-  fun genericStage(name: String, vararg arguments: Any): Pipeline =
-    append(GenericStage.ofName(name).withArguments(arguments))
-
   /**
    * Adds a stage to the pipeline by specifying the stage name as an argument. This does not offer
    * any type safety on the stage params and requires the caller to know the order (and optionally

firebase-firestore/src/main/java/com/google/firebase/firestore/pipeline/expressions.kt

@@ -290,7 +290,7 @@ abstract class Expr internal constructor() {
       return Field(fieldPath.internalPath)
     }
 
-    @JvmStatic fun generic(name: String, vararg expr: Expr) = FunctionExpr(name, expr)
+    @JvmStatic fun generic(name: String, vararg expr: Expr): Expr = FunctionExpr(name, expr)
 
     /**
      * Creates an expression that performs a logical 'AND' operation.