Skip to content

Commit 05d4642

Browse files
committed
Move FeedbackSender instantiation to getInstance()
1 parent 7307517 commit 05d4642

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

firebase-appdistribution/src/main/java/com/google/firebase/appdistribution/impl/FeedbackActivity.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
import android.widget.EditText;
2121
import android.widget.Toast;
2222
import androidx.appcompat.app.AppCompatActivity;
23-
import com.google.firebase.FirebaseApp;
2423

2524
/** Activity for tester to compose and submit feedback. */
2625
public class FeedbackActivity extends AppCompatActivity {
@@ -41,7 +40,7 @@ protected void onCreate(Bundle savedInstanceState) {
4140
super.onCreate(savedInstanceState);
4241
releaseName = getIntent().getStringExtra(RELEASE_NAME_EXTRA_KEY);
4342
screenshot = getIntent().getParcelableExtra(SCREENSHOT_EXTRA_KEY);
44-
feedbackSender = FirebaseApp.getInstance().get(FeedbackSender.class);
43+
feedbackSender = FeedbackSender.getInstance();
4544
setContentView(R.layout.activity_feedback);
4645
}
4746

firebase-appdistribution/src/main/java/com/google/firebase/appdistribution/impl/FeedbackSender.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,11 @@
1515
package com.google.firebase.appdistribution.impl;
1616

1717
import android.graphics.Bitmap;
18+
import androidx.annotation.NonNull;
1819
import com.google.android.gms.tasks.Task;
20+
import com.google.firebase.FirebaseApp;
21+
import com.google.firebase.appdistribution.FirebaseAppDistribution;
22+
import com.google.firebase.appdistribution.internal.FirebaseAppDistributionProxy;
1923

2024
/** Sends tester feedback to the Tester API. */
2125
class FeedbackSender {
@@ -26,6 +30,11 @@ class FeedbackSender {
2630
this.testerApiClient = testerApiClient;
2731
}
2832

33+
@NonNull
34+
static FeedbackSender getInstance() {
35+
return FirebaseApp.getInstance().get(FeedbackSender.class);
36+
}
37+
2938
/** Send feedback text and screenshot to the Tester API for the given release. */
3039
Task<Void> sendFeedback(String releaseName, String feedbackText, Bitmap screenshot) {
3140
return testerApiClient

0 commit comments

Comments
 (0)