Review

Author: schmidt-sebastian

firebase-firestore/src/main/java/com/google/firebase/firestore/model/mutation/NumericIncrementTransformOperation.java

@@ -14,6 +14,8 @@
 
 package com.google.firebase.firestore.model.mutation;
 
+import static com.google.firebase.firestore.model.value.ProtoValues.isDouble;
+import static com.google.firebase.firestore.model.value.ProtoValues.isInteger;
 import static com.google.firebase.firestore.util.Assert.fail;
 import static com.google.firebase.firestore.util.Assert.hardAssert;
 
@@ -121,12 +123,4 @@ private long operandAsLong() {
               + operand.getClass().getCanonicalName());
     }
   }
-
-  private boolean isInteger(@Nullable Value value) {
-    return value != null && value.getValueTypeCase() == Value.ValueTypeCase.INTEGER_VALUE;
-  }
-
-  private boolean isDouble(@Nullable Value value) {
-    return value != null && value.getValueTypeCase() == Value.ValueTypeCase.DOUBLE_VALUE;
-  }
 }

firebase-firestore/src/main/java/com/google/firebase/firestore/model/value/ProtoValues.java

@@ -391,11 +391,19 @@ private static void canonifyArray(StringBuilder builder, ArrayValue arrayValue)
     builder.append("]");
   }
 
+  /** Returns true if `value` is either a INTEGER_VALUE. */
+  public static boolean isInteger(@Nullable Value value) {
+    return value != null && value.getValueTypeCase() == Value.ValueTypeCase.INTEGER_VALUE;
+  }
+
+  /** Returns true if `value` is either a DOUBLE_VALUE. */
+  public static boolean isDouble(@Nullable Value value) {
+    return value != null && value.getValueTypeCase() == Value.ValueTypeCase.DOUBLE_VALUE;
+  }
+
   /** Returns true if `value` is either a INTEGER_VALUE or a DOUBLE_VALUE. */
   public static boolean isNumber(@Nullable Value value) {
-    return value != null
-        && (value.getValueTypeCase() == Value.ValueTypeCase.INTEGER_VALUE
-            || value.getValueTypeCase() == Value.ValueTypeCase.DOUBLE_VALUE);
+    return isInteger(value) || isDouble(value);
   }
 
   /** Returns true if `value` is an ARRAY_VALUE. */