Fixing tests

Manny Jimenez · Manny Jimenez · commit 1522061c0a71 · 2022-02-03T12:12:42.000-05:00
diff --git a/firebase-appdistribution/src/test/java/com/google/firebase/appdistribution/FirebaseAppDistributionTest.java b/firebase-appdistribution/src/test/java/com/google/firebase/appdistribution/FirebaseAppDistributionTest.java
@@ -188,13 +188,12 @@ public void checkForNewRelease_whenCheckForNewReleaseFails_throwsError() {
   }
 
   @Test
-  public void checkForNewRelease_callsSignInTester() {
-    when(mockNewReleaseFetcher.checkForNewRelease())
-        .thenReturn(Tasks.forResult(TEST_RELEASE_NEWER_AAB_INTERNAL.build()));
+  public void checkForNewRelease_testerIsNotSignedIn_taskFails() {
+    when(firebaseAppDistribution.isTesterSignedIn()).thenReturn(false);
 
-    firebaseAppDistribution.checkForNewRelease();
+    Task<AppDistributionRelease> task = firebaseAppDistribution.checkForNewRelease();
 
-    verify(mockTesterSignInManager, times(1)).signInTester();
+    assertTaskFailure(task, AUTHENTICATION_FAILURE, AUTHENTICATION_ERROR);
   }
 
   @Test

Original file line number	Diff line number	Diff line change
`@@ -188,13 +188,12 @@ public void checkForNewRelease_whenCheckForNewReleaseFails_throwsError() {`
`188`	`188`	`}`
`189`	`189`
`190`	`190`	`@Test`
`191`		`- public void checkForNewRelease_callsSignInTester() {`
`192`		`- when(mockNewReleaseFetcher.checkForNewRelease())`
`193`		`- .thenReturn(Tasks.forResult(TEST_RELEASE_NEWER_AAB_INTERNAL.build()));`
	`191`	`+ public void checkForNewRelease_testerIsNotSignedIn_taskFails() {`
	`192`	`+ when(firebaseAppDistribution.isTesterSignedIn()).thenReturn(false);`
`194`	`193`
`195`		`- firebaseAppDistribution.checkForNewRelease();`
	`194`	`+ Task<AppDistributionRelease> task = firebaseAppDistribution.checkForNewRelease();`
`196`	`195`
`197`		`- verify(mockTesterSignInManager, times(1)).signInTester();`
	`196`	`+ assertTaskFailure(task, AUTHENTICATION_FAILURE, AUTHENTICATION_ERROR);`
`198`	`197`	`}`
`199`	`198`
`200`	`199`	`@Test`