test brooken

Author: schmidt-sebastian

firebase-firestore/src/main/java/com/google/firebase/firestore/core/View.java

@@ -114,52 +114,6 @@ public <D extends MaybeDocument> DocumentChanges computeDocChanges(
     return computeDocChanges(docChanges, null);
   }
 
-  /**
-   * Computes the initial set of document changes based on the provided documents.
-   *
-   * <p>Unlike `computeDocChanges`, documents with committed mutations don't raise
-   * `hasPendingWrites`. This distinction allows us to only raise `hasPendingWrite` events for
-   * documents that changed during the lifetime of the View.
-   *
-   * @param docs The docs to apply to this view.
-   * @return A new set of docs, changes, and refill flag.
-   */
-  public <D extends MaybeDocument> DocumentChanges computeInitialChanges(
-      ImmutableSortedMap<DocumentKey, D> docs) {
-    hardAssert(
-        this.documentSet.isEmpty(), "computeInitialChanges() called when docs are already present");
-
-    DocumentViewChangeSet changeSet = new DocumentViewChangeSet();
-    ImmutableSortedSet<DocumentKey> newMutatedKeys = this.mutatedKeys;
-    DocumentSet newDocumentSet = this.documentSet;
-
-    for (Map.Entry<DocumentKey, ? extends MaybeDocument> entry : docs) {
-      DocumentKey key = entry.getKey();
-      MaybeDocument maybeDoc = entry.getValue();
-
-      if (maybeDoc instanceof Document) {
-        Document doc = (Document) maybeDoc;
-        if (this.query.matches(doc)) {
-          changeSet.addChange(DocumentViewChange.create(Type.ADDED, doc));
-          newDocumentSet = newDocumentSet.add(doc);
-          if (doc.hasLocalMutations()) {
-            newMutatedKeys = newMutatedKeys.insert(key);
-          }
-        }
-      }
-    }
-
-    if (this.query.hasLimit()) {
-      for (long i = newDocumentSet.size() - this.query.getLimit(); i > 0; --i) {
-        Document oldDoc = newDocumentSet.getLastDocument();
-        newDocumentSet = newDocumentSet.remove(oldDoc.getKey());
-        newMutatedKeys = newMutatedKeys.remove(oldDoc.getKey());
-        changeSet.addChange(DocumentViewChange.create(Type.REMOVED, oldDoc));
-      }
-    }
-    return new DocumentChanges(newDocumentSet, changeSet, newMutatedKeys, /*needsRefill=*/ false);
-  }
-
   /**
    * Iterates over a set of doc changes, applies the query limit, and computes what the new results
    * should be, what the changes were, and whether we may need to go back to the local cache for

firebase-firestore/src/test/java/com/google/firebase/firestore/core/ViewTest.java

@@ -566,7 +566,7 @@ public void testRaisesHasPendingWritesForPendingMutationsInInitialSnapshot() {
     Document doc1 = doc("rooms/eros/messages/1", 0, map(), Document.DocumentState.LOCAL_MUTATIONS);
     View view = new View(query, DocumentKey.emptyKeySet());
 
-    View.DocumentChanges changes = view.computeInitialChanges(docUpdates(doc1));
+    View.DocumentChanges changes = view.computeDocChanges(docUpdates(doc1));
     ViewChange viewChange = view.applyChanges(changes);
 
     assertTrue(viewChange.getSnapshot().hasPendingWrites());
@@ -579,7 +579,7 @@ public void testDoesntRaiseHasPendingWritesForCommittedMutationsInInitialSnapsho
         doc("rooms/eros/messages/1", 0, map(), Document.DocumentState.COMMITTED_MUTATIONS);
     View view = new View(query, DocumentKey.emptyKeySet());
 
-    View.DocumentChanges changes = view.computeInitialChanges(docUpdates(doc1));
+    View.DocumentChanges changes = view.computeDocChanges(docUpdates(doc1));
     ViewChange viewChange = view.applyChanges(changes);
 
     assertFalse(viewChange.getSnapshot().hasPendingWrites());

firebase-firestore/src/test/resources/json/write_spec_test.json

@@ -5115,7 +5115,7 @@
     "describeName": "Writes:",
     "itName": "Held writes are released when there are no queries left.",
     "tags": [
-      "eager-gc"
+      "eager-gc", "exclusive"
     ],
     "comment": "This test expects a new target id for a new listen, but without eager gc, the same target id is reused",
     "config": {