Generate a SessionEvent based on the SessionState

Author: mrober

firebase-sessions/src/main/kotlin/com/google/firebase/sessions/FirebaseSessions.kt

@@ -22,7 +22,6 @@ import androidx.annotation.Discouraged
 import com.google.firebase.FirebaseApp
 import com.google.firebase.ktx.Firebase
 import com.google.firebase.ktx.app
-import com.google.firebase.sessions.EventType.SESSION_START
 
 class FirebaseSessions internal constructor(firebaseApp: FirebaseApp) {
   private val sessionGenerator = SessionGenerator(collectEvents = true)
@@ -42,16 +41,7 @@ class FirebaseSessions internal constructor(firebaseApp: FirebaseApp) {
 
   private fun initiateSessionStart() {
     val sessionState = sessionGenerator.generateNewSession()
-    val sessionEvent =
-      SessionEvent(
-        eventType = SESSION_START,
-        sessionData =
-          SessionInfo(
-            sessionState.sessionId,
-            sessionState.firstSessionId,
-            sessionState.sessionIndex
-          ),
-      )
+    val sessionEvent = SessionEvent.sessionStart(sessionState)
 
     Log.i(TAG, "Initiate session start: $sessionEvent")
   }

firebase-sessions/src/main/kotlin/com/google/firebase/sessions/SessionEvent.kt

@@ -29,7 +29,20 @@ internal data class SessionEvent(
 
   /** Information about the session triggering the event. */
   val sessionData: SessionInfo,
-)
+) {
+  companion object {
+    fun sessionStart(sessionState: SessionState) =
+      SessionEvent(
+        eventType = EventType.SESSION_START,
+        sessionData =
+          SessionInfo(
+            sessionState.sessionId,
+            sessionState.firstSessionId,
+            sessionState.sessionIndex,
+          ),
+      )
+  }
+}
 
 /** Enum denoting all possible session event types. */
 internal enum class EventType(val number: Int) {

firebase-sessions/src/test/kotlin/com/google/firebase/sessions/SessionEventTest.kt

@@ -0,0 +1,48 @@
+/*
+ * Copyright 2023 Google LLC
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.google.firebase.sessions
+
+import com.google.common.truth.Truth.assertThat
+import org.junit.Test
+
+class SessionEventTest {
+  @Test
+  fun sessionStart_populatesSessionStateCorrectly() {
+    val sessionState =
+      SessionState(
+        sessionId = "a1b2c3",
+        firstSessionId = "a1a1a1",
+        collectEvents = true,
+        sessionIndex = 3,
+      )
+
+    val sessionEvent = SessionEvent.sessionStart(sessionState)
+
+    assertThat(sessionEvent)
+      .isEqualTo(
+        SessionEvent(
+          eventType = EventType.SESSION_START,
+          sessionData =
+            SessionInfo(
+              sessionId = "a1b2c3",
+              firstSessionId = "a1a1a1",
+              sessionIndex = 3,
+            )
+        )
+      )
+  }
+}