Skip to content

Commit 1a9ca97

Browse files
authored
Increase Remote Config's default timeout. (#667)
The default timeout of 5 seconds is way too short. The network is not guaranteed to be in a good state, and this may cause apps to crash unexpectedly. This is the source of some flakiness in tests as well. This change increases the timeout to 30 seconds. Updates are infrequent and run in the background, so this should not be a problem. Edit: The timeout is now changed to 60 seconds to match the iOS implementation.
1 parent 484371e commit 1a9ca97

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

firebase-config/src/main/java/com/google/firebase/remoteconfig/RemoteConfigComponent.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ public class RemoteConfigComponent {
6060
/** Name of the file where defaults configs are stored. */
6161
public static final String DEFAULTS_FILE_NAME = "defaults";
6262
/** Timeout for the call to the Firebase Remote Config servers in second. */
63-
public static final long NETWORK_CONNECTION_TIMEOUT_IN_SECONDS = 5;
63+
public static final long NETWORK_CONNECTION_TIMEOUT_IN_SECONDS = 60;
6464

6565
private static final String FIREBASE_REMOTE_CONFIG_FILE_NAME_PREFIX = "frc";
6666
private static final String PREFERENCES_FILE_NAME = "settings";

0 commit comments

Comments
 (0)