Skip to content

Commit 1cad5d5

Browse files
committed
Add missing GaugeCounter increment. (#6966)
As part of looking into refactoring `GaugeCounter` I noticed I'd missed this increment.
1 parent d181c2c commit 1cad5d5

File tree

3 files changed

+4
-2
lines changed

3 files changed

+4
-2
lines changed

firebase-perf/src/main/java/com/google/firebase/perf/session/gauges/CpuGaugeCollector.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -186,6 +186,7 @@ private synchronized void scheduleCpuMetricCollectionOnce(Timer referenceTime) {
186186
CpuMetricReading currCpuReading = syncCollectCpuMetric(referenceTime);
187187
if (currCpuReading != null) {
188188
cpuMetricReadings.add(currCpuReading);
189+
GaugeCounter.INSTANCE.incrementCounter();
189190
}
190191
},
191192
/* initialDelay */ 0,

firebase-perf/src/main/java/com/google/firebase/perf/session/gauges/MemoryGaugeCollector.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -149,6 +149,7 @@ private synchronized void scheduleMemoryMetricCollectionOnce(Timer referenceTime
149149
AndroidMemoryReading memoryReading = syncCollectMemoryMetric(referenceTime);
150150
if (memoryReading != null) {
151151
memoryMetricReadings.add(memoryReading);
152+
GaugeCounter.INSTANCE.incrementCounter();
152153
}
153154
},
154155
/* initialDelay */ 0,

firebase-perf/src/test/java/com/google/firebase/perf/session/gauges/GaugeManagerTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -335,7 +335,7 @@ public void testGaugeCounterStartsAJobToConsumeTheGeneratedMetrics() throws Inte
335335
PerfSession fakeSession = createTestSession(1);
336336
testGaugeManager.setApplicationProcessState(ApplicationProcessState.FOREGROUND);
337337
testGaugeManager.startCollectingGauges(fakeSession);
338-
GaugeCounter.INSTANCE.setGaugeManager(testGaugeManager);
338+
GaugeCounter.setGaugeManager(testGaugeManager);
339339

340340
// There's no job to log the gauges.
341341
assertThat(fakeScheduledExecutorService.isEmpty()).isTrue();
@@ -377,7 +377,7 @@ public void testUpdateAppStateHandlesMultipleAppStates() {
377377
fakeSession.setGaugeAndEventCollectionEnabled(true);
378378
testGaugeManager.setApplicationProcessState(ApplicationProcessState.FOREGROUND);
379379
testGaugeManager.startCollectingGauges(fakeSession);
380-
GaugeCounter.INSTANCE.setGaugeManager(testGaugeManager);
380+
GaugeCounter.setGaugeManager(testGaugeManager);
381381

382382
// Generate metrics that don't exceed the GaugeCounter.MAX_COUNT.
383383
generateMetricsAndIncrementCounter(10);

0 commit comments

Comments
 (0)