Propagate exceptions to the caller if Fis getToken call fails with an

exception.

Author: ankitaj224

firebase-installations/src/main/java/com/google/firebase/installations/FirebaseInstallations.java

@@ -306,12 +306,12 @@ private void triggerOnStateReached(PersistedInstallationEntry persistedInstallat
     }
   }
 
-  private void triggerOnException(PersistedInstallationEntry prefs, Exception exception) {
+  private void triggerOnException(Exception exception) {
     synchronized (lock) {
       Iterator<StateListener> it = listeners.iterator();
       while (it.hasNext()) {
         StateListener l = it.next();
-        boolean doneListening = l.onException(prefs, exception);
+        boolean doneListening = l.onException(exception);
         if (doneListening) {
           it.remove();
         }
@@ -367,7 +367,7 @@ private void doNetworkCallIfNecessary(boolean forceRefresh) {
         return;
       }
     } catch (FirebaseInstallationsException e) {
-      triggerOnException(prefs, e);
+      triggerOnException(e);
       return;
     }
 
@@ -381,11 +381,11 @@ private void doNetworkCallIfNecessary(boolean forceRefresh) {
 
     // Let the caller know about the result.
     if (prefs.isErrored()) {
-      triggerOnException(prefs, new FirebaseInstallationsException(Status.BAD_CONFIG));
+      triggerOnException(new FirebaseInstallationsException(Status.BAD_CONFIG));
     } else if (prefs.isNotGenerated()) {
       // If there is no fid it means the call failed with an auth error. Simulate an
       // IOException so that the caller knows to try again.
-      triggerOnException(prefs, new IOException(AUTH_ERROR_MSG));
+      triggerOnException(new IOException(AUTH_ERROR_MSG));
     } else {
       triggerOnStateReached(prefs);
     }

firebase-installations/src/main/java/com/google/firebase/installations/GetAuthTokenListener.java

@@ -44,14 +44,8 @@ public boolean onStateReached(PersistedInstallationEntry persistedInstallationEn
   }
 
   @Override
-  public boolean onException(
-      PersistedInstallationEntry persistedInstallationEntry, Exception exception) {
-    if (persistedInstallationEntry.isErrored()
-        || persistedInstallationEntry.isNotGenerated()
-        || persistedInstallationEntry.isUnregistered()) {
-      resultTaskCompletionSource.trySetException(exception);
-      return true;
-    }
-    return false;
+  public boolean onException(Exception exception) {
+    resultTaskCompletionSource.trySetException(exception);
+    return true;
   }
 }

firebase-installations/src/main/java/com/google/firebase/installations/GetIdListener.java

@@ -42,8 +42,7 @@ public boolean onStateReached(PersistedInstallationEntry persistedInstallationEn
   }
 
   @Override
-  public boolean onException(
-      PersistedInstallationEntry persistedInstallationEntry, Exception exception) {
+  public boolean onException(Exception exception) {
     return false;
   }
 }

firebase-installations/src/main/java/com/google/firebase/installations/StateListener.java

@@ -27,5 +27,5 @@ interface StateListener {
    * Returns {@code true} if an exception is thrown while registering a Firebase Installation,
    * {@code false} otherwise.
    */
-  boolean onException(PersistedInstallationEntry persistedInstallationEntry, Exception exception);
+  boolean onException(Exception exception);
 }