Skip to content

Commit 1deab86

Browse files
committed
[smoke-test] Revive messaging test
1 parent 89681f0 commit 1deab86

File tree

3 files changed

+7
-9
lines changed

3 files changed

+7
-9
lines changed

smoke-tests/build.gradle

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,8 +77,7 @@ dependencies {
7777
implementation "com.google.firebase:firebase-firestore"
7878
implementation "com.google.firebase:firebase-functions"
7979
implementation "com.google.firebase:firebase-inappmessaging"
80-
// TODO(yifany): Restore after messaging in github is up to date
81-
// implementation "com.google.firebase:firebase-messaging"
80+
implementation "com.google.firebase:firebase-messaging"
8281
implementation "com.google.firebase:firebase-ml-modeldownloader"
8382
implementation "com.google.firebase:firebase-perf"
8483
implementation "com.google.firebase:firebase-storage"

smoke-tests/src/main/java/com/google/firebase/testing/BuildOnlyTest.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818

1919
import com.google.firebase.appindexing.FirebaseAppIndex;
2020
import com.google.firebase.inappmessaging.FirebaseInAppMessaging;
21-
// import com.google.firebase.messaging.FirebaseMessaging;
21+
import com.google.firebase.messaging.FirebaseMessaging;
2222
import com.google.firebase.ml.modeldownloader.FirebaseModelDownloader;
2323
import com.google.firebase.perf.FirebasePerformance;
2424
import org.junit.Test;
@@ -41,10 +41,10 @@ public void inappmessaging_IsNotNull() {
4141
assertThat(FirebaseInAppMessaging.getInstance()).isNotNull();
4242
}
4343

44-
// @Test
45-
// public void messaging_IsNotNull() {
46-
// assertThat(FirebaseMessaging.getInstance()).isNotNull();
47-
// }
44+
@Test
45+
public void messaging_IsNotNull() {
46+
assertThat(FirebaseMessaging.getInstance()).isNotNull();
47+
}
4848

4949
@Test
5050
public void modelDownloader_IsNotNull() {

smoke-tests/src/main/java/com/google/firebase/testing/TestSuite.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,7 @@
3131
DynamicLinksTest.class,
3232
FirestoreTest.class,
3333
FunctionsTest.class,
34-
// TODO(yifany): Disable as it has been failing since 01/26. Troubleshooting offline.
35-
// RemoteConfigTest.class,
34+
RemoteConfigTest.class,
3635
StorageTest.class,
3736
})
3837
public final class TestSuite {}

0 commit comments

Comments
 (0)