Skip to content

Commit 20a501e

Browse files
committed
Do not fail fast. Run through tests for all SDKs and display errors at the end.
1 parent e7a417c commit 20a501e

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

ci/fireci/fireciplugins/macrobenchmark.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,11 @@
1818
import logging
1919
import os
2020
import random
21+
import shutil
2122
import sys
2223

2324
import click
2425
import pystache
25-
import shutil
2626
import yaml
2727

2828
from fireci import ci_command
@@ -48,7 +48,11 @@ async def _launch_macrobenchmark_test():
4848

4949
with chdir('macrobenchmark'):
5050
runners = [MacrobenchmarkTest(k, v, artifact_versions) for k, v in config.items()]
51-
await asyncio.gather(*[x.run() for x in runners])
51+
results = await asyncio.gather(*[x.run() for x in runners], return_exceptions=True)
52+
53+
if any(map(lambda x: isinstance(x, Exception), results)):
54+
_logger.error(f'Exceptions: {[x for x in results if (isinstance(x, Exception))]}')
55+
raise click.ClickException('Macrobenchmark test failed with above errors.')
5256

5357
_logger.info('Macrobenchmark test finished.')
5458

0 commit comments

Comments
 (0)