Skip to content

Commit 23a82a5

Browse files
committed
fix log level
1 parent 860b24e commit 23a82a5

File tree

1 file changed

+13
-13
lines changed

1 file changed

+13
-13
lines changed

firebase-perf/src/main/java/com/google/firebase/perf/application/FrameMetricsRecorder.java

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ public FrameMetricsRecorder(Activity activity) {
7070
/** Starts recording FrameMetrics for the activity window. */
7171
public void start() {
7272
if (isRecording) {
73-
logger.warn(
73+
logger.debug(
7474
"FrameMetricsAggregator is already recording %s", activity.getClass().getSimpleName());
7575
return;
7676
}
@@ -85,18 +85,18 @@ public void start() {
8585
*/
8686
public Optional<PerfFrameMetrics> stop() {
8787
if (!isRecording) {
88-
logger.warn("Cannot stop because no recording was started");
88+
logger.debug("Cannot stop because no recording was started");
8989
return Optional.absent();
9090
}
9191
if (!fragmentSnapshotMap.isEmpty()) {
92-
logger.warn(
92+
logger.debug(
9393
"Sub-recordings are still ongoing! Sub-recordings should be stopped first before stopping Activity screen trace.");
9494
}
9595
Optional<PerfFrameMetrics> data = this.snapshot();
9696
try {
9797
frameMetricsAggregator.remove(activity);
9898
} catch (IllegalArgumentException err) {
99-
logger.debug(
99+
logger.warn(
100100
"View not hardware accelerated. Unable to collect FrameMetrics. %s", err.toString());
101101
return Optional.absent();
102102
}
@@ -114,18 +114,18 @@ public Optional<PerfFrameMetrics> stop() {
114114
*/
115115
public void startFragment(Fragment fragment) {
116116
if (!isRecording) {
117-
logger.warn("Cannot start sub-recording because FrameMetricsAggregator is not recording");
117+
logger.debug("Cannot start sub-recording because FrameMetricsAggregator is not recording");
118118
return;
119119
}
120120
if (fragmentSnapshotMap.containsKey(fragment)) {
121-
logger.warn(
121+
logger.debug(
122122
"Cannot start sub-recording because one is already ongoing with the key %s",
123123
fragment.getClass().getSimpleName());
124124
return;
125125
}
126126
Optional<PerfFrameMetrics> snapshot = this.snapshot();
127127
if (!snapshot.isAvailable()) {
128-
logger.warn("startFragment(%s): snapshot() failed", fragment.getClass().getSimpleName());
128+
logger.debug("startFragment(%s): snapshot() failed", fragment.getClass().getSimpleName());
129129
return;
130130
}
131131
fragmentSnapshotMap.put(fragment, snapshot.get());
@@ -141,19 +141,19 @@ public void startFragment(Fragment fragment) {
141141
*/
142142
public Optional<PerfFrameMetrics> stopFragment(Fragment fragment) {
143143
if (!isRecording) {
144-
logger.warn("Cannot stop sub-recording because FrameMetricsAggregator is not recording");
144+
logger.debug("Cannot stop sub-recording because FrameMetricsAggregator is not recording");
145145
return Optional.absent();
146146
}
147147
if (!fragmentSnapshotMap.containsKey(fragment)) {
148-
logger.warn(
148+
logger.debug(
149149
"Sub-recording associated with key %s was not started or does not exist",
150150
fragment.getClass().getSimpleName());
151151
return Optional.absent();
152152
}
153153
PerfFrameMetrics snapshotStart = fragmentSnapshotMap.remove(fragment);
154154
Optional<PerfFrameMetrics> snapshotEnd = this.snapshot();
155155
if (!snapshotEnd.isAvailable()) {
156-
logger.warn("stopFragment(%s): snapshot() failed", fragment.getClass().getSimpleName());
156+
logger.debug("stopFragment(%s): snapshot() failed", fragment.getClass().getSimpleName());
157157
return Optional.absent();
158158
}
159159
return Optional.of(snapshotEnd.get().deltaFrameMetricsFromSnapshot(snapshotStart));
@@ -167,17 +167,17 @@ public Optional<PerfFrameMetrics> stopFragment(Fragment fragment) {
167167
*/
168168
private Optional<PerfFrameMetrics> snapshot() {
169169
if (!isRecording) {
170-
logger.warn("No recording has been started.");
170+
logger.debug("No recording has been started.");
171171
return Optional.absent();
172172
}
173173
SparseIntArray[] arr = this.frameMetricsAggregator.getMetrics();
174174
if (arr == null) {
175-
logger.warn("FrameMetricsAggregator.mMetrics is uninitialized.");
175+
logger.debug("FrameMetricsAggregator.mMetrics is uninitialized.");
176176
return Optional.absent();
177177
}
178178
SparseIntArray frameTimes = arr[FrameMetricsAggregator.TOTAL_INDEX];
179179
if (frameTimes == null) {
180-
logger.warn("FrameMetricsAggregator.mMetrics[TOTAL_INDEX] is uninitialized.");
180+
logger.debug("FrameMetricsAggregator.mMetrics[TOTAL_INDEX] is uninitialized.");
181181
return Optional.absent();
182182
}
183183
return Optional.of(FrameMetricsCalculator.calculateFrameMetrics(arr));

0 commit comments

Comments
 (0)