Skip to content

Commit 274eb37

Browse files
committed
Fixed few more comments.
1 parent e14dbed commit 274eb37

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

firebase-perf/CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ Refer [GMaven](https://maven.google.com/web/index.html?q=firebase-perf#com.googl
2323

2424
* {{fixed}} Fixed a bug where screen traces were not capturing frame metrics for multi-activity apps.
2525
* {{feature}} Added support for measuring screen performance metrics for "Activity Fragments" out-of-the-box.
26-
* {{fixed}} Exclude custom attributes whose key/value length is 0.
26+
* {{fixed}} Excluded custom attributes whose key/value length is 0.
2727

2828
## Released
2929

firebase-perf/src/test/java/com/google/firebase/perf/metrics/validator/FirebasePerfTraceValidatorTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ public void screenTrace_shouldNotAllowNonPositiveTotalFrames() {
169169
}
170170

171171
@Test
172-
public void traceValidator_invalidCustomAttriubute_skipsAttribute() {
172+
public void traceValidator_invalidCustomAttribute_marksPerfMetricInvalid() {
173173
TraceMetric.Builder trace = createValidTraceMetric().putCustomAttributes("_test", "value");
174174
assertThat(new FirebasePerfTraceValidator(trace.build()).isValidPerfMetric()).isFalse();
175175

0 commit comments

Comments
 (0)