Skip to content

Commit 2a5c896

Browse files
lfkelloggkaibolay
authored andcommitted
Some final synchronized block cleanup (#4528)
1 parent 42ecbc9 commit 2a5c896

File tree

2 files changed

+1
-5
lines changed

2 files changed

+1
-5
lines changed

firebase-appdistribution/src/main/java/com/google/firebase/appdistribution/impl/AabUpdater.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -160,11 +160,7 @@ private void openRedirectUrlInPlay(String redirectUrl, Activity hostActivity) {
160160
updateIntent.setData(Uri.parse(redirectUrl));
161161
updateIntent.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK);
162162
LogWrapper.v(TAG, "Redirecting to play");
163-
164-
// Launch the intent before the synchronized block to avoid failing to update in the rare
165-
// scenario where the activity moves to the background while we're awaiting the lock.
166163
hostActivity.startActivity(updateIntent);
167-
168164
updateTaskCache.setProgress(
169165
UpdateProgressImpl.builder()
170166
.setApkBytesDownloaded(-1)

firebase-appdistribution/src/main/java/com/google/firebase/appdistribution/impl/FirebaseAppDistributionImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -254,7 +254,7 @@ public void signOutTester() {
254254
}
255255

256256
@Override
257-
public synchronized Task<AppDistributionRelease> checkForNewRelease() {
257+
public Task<AppDistributionRelease> checkForNewRelease() {
258258
return checkForNewReleaseTaskCache.getOrCreateTask(
259259
() ->
260260
assertTesterIsSignedIn()

0 commit comments

Comments
 (0)