Skip to content

Commit 2f0a18a

Browse files
lfkelloggkaibolay
authored andcommitted
Use BufferedOutputStream to prevent StrictMode violations (#4538)
1 parent d9b5364 commit 2f0a18a

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

firebase-appdistribution/src/main/java/com/google/firebase/appdistribution/impl/ScreenshotTaker.java

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@
3333
import com.google.firebase.annotations.concurrent.Background;
3434
import com.google.firebase.appdistribution.FirebaseAppDistributionException;
3535
import com.google.firebase.appdistribution.FirebaseAppDistributionException.Status;
36+
import java.io.BufferedOutputStream;
3637
import java.io.FileNotFoundException;
37-
import java.io.FileOutputStream;
3838
import java.io.IOException;
3939
import java.util.concurrent.Executor;
4040

@@ -141,7 +141,7 @@ private Uri writeToFile(@Nullable Bitmap bitmap) throws FirebaseAppDistributionE
141141
// First delete the previous file if it's still there
142142
deleteScreenshot();
143143

144-
try (FileOutputStream outputStream = openFileOutputStream()) {
144+
try (BufferedOutputStream outputStream = openFileOutputStream()) {
145145
// PNG is a lossless format, the compression factor (100) is ignored
146146
bitmap.compress(Bitmap.CompressFormat.PNG, /* quality= */ 100, outputStream);
147147
} catch (IOException e) {
@@ -157,9 +157,10 @@ void deleteScreenshot() {
157157
firebaseApp.getApplicationContext().deleteFile(SCREENSHOT_FILE_NAME);
158158
}
159159

160-
private FileOutputStream openFileOutputStream() throws FileNotFoundException {
161-
return firebaseApp
162-
.getApplicationContext()
163-
.openFileOutput(SCREENSHOT_FILE_NAME, Context.MODE_PRIVATE);
160+
private BufferedOutputStream openFileOutputStream() throws FileNotFoundException {
161+
return new BufferedOutputStream(
162+
firebaseApp
163+
.getApplicationContext()
164+
.openFileOutput(SCREENSHOT_FILE_NAME, Context.MODE_PRIVATE));
164165
}
165166
}

0 commit comments

Comments
 (0)