Skip to content

Commit 34702b3

Browse files
author
Manny Jimenez
committed
Responding to feedback
1 parent 56a8220 commit 34702b3

File tree

3 files changed

+3
-7
lines changed

3 files changed

+3
-7
lines changed

firebase-app-distribution/src/main/java/com/google/firebase/app/distribution/InstallActivity.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,13 +28,11 @@
2828
* Activity opened during installation in {@link FirebaseAppDistribution} after APK download is
2929
* finished.
3030
*/
31-
class InstallActivity extends AppCompatActivity {
31+
public class InstallActivity extends AppCompatActivity {
3232
private static final String TAG = "InstallActivity: ";
3333
private boolean unknownSourceEnablementInProgress = false;
3434
private boolean installInProgress = false;
3535

36-
public InstallActivity() {}
37-
3836
@Override
3937
public void onResume() {
4038
super.onResume();

firebase-app-distribution/src/main/java/com/google/firebase/app/distribution/ReleaseIdentificationUtils.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ final class ReleaseIdentificationUtils {
3434
private static final int BYTES_IN_LONG = 8;
3535

3636
@Nullable
37-
public static String extractInternalAppSharingArtifactId(@NonNull Context appContext) {
37+
static String extractInternalAppSharingArtifactId(@NonNull Context appContext) {
3838
try {
3939
PackageInfo packageInfo =
4040
appContext
@@ -51,7 +51,7 @@ public static String extractInternalAppSharingArtifactId(@NonNull Context appCon
5151
}
5252

5353
@Nullable
54-
public static String calculateApkHash(@NonNull File file) {
54+
static String calculateApkHash(@NonNull File file) {
5555
LogWrapper.getInstance().v(TAG + "Calculating release id for " + file.getPath());
5656
LogWrapper.getInstance().v(TAG + "File size: " + file.length());
5757

firebase-app-distribution/src/main/java/com/google/firebase/app/distribution/SignInResultActivity.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,6 @@
2525
public class SignInResultActivity extends AppCompatActivity {
2626
private static final String TAG = "SignInResultActivity:";
2727

28-
public SignInResultActivity() {}
29-
3028
@Override
3129
public void onCreate(@NonNull Bundle savedInstanceBundle) {
3230
super.onCreate(savedInstanceBundle);

0 commit comments

Comments
 (0)