Skip to content

Commit 35adc36

Browse files
authored
Keep smoke tests up to date. (#2656)
* Keep smoke tests up to date. - remove smoke tests for ml-vision - restore smoke tests for fireperf - Fix invalid call to FirebaseAppIndex.getInstance
1 parent 0ed82c8 commit 35adc36

File tree

2 files changed

+7
-18
lines changed

2 files changed

+7
-18
lines changed

smoke-tests/build.gradle

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,6 @@ dependencies {
7777
implementation "com.google.firebase:firebase-inappmessaging"
7878
// TODO(yifany): Restore after messaging in github is up to date
7979
// implementation "com.google.firebase:firebase-messaging"
80-
implementation "com.google.firebase:firebase-ml-vision"
8180
implementation "com.google.firebase:firebase-perf"
8281
implementation "com.google.firebase:firebase-storage"
8382

@@ -86,17 +85,11 @@ dependencies {
8685
implementation "androidx.test:runner:1.2.0"
8786
implementation "com.google.truth:truth:0.44"
8887
implementation "junit:junit:4.12"
88+
implementation "androidx.test:core:1.3.0"
8989

9090
// Common utilities (instrumentation side)
91-
androidTestImplementation "androidx.test:core:1.2.0"
9291
androidTestImplementation "androidx.test:runner:1.2.0"
9392
androidTestImplementation "junit:junit:4.12"
94-
95-
// TODO(yifany): Remove the temporary fix after b/164175567
96-
// https://firebase.google.com/support/release-notes/android#mlkit-self-serve-fixes
97-
implementation "com.google.android.gms:play-services-vision:20.1.1"
98-
implementation "com.google.android.gms:play-services-vision-common:19.1.1"
99-
implementation "com.google.android.gms:play-services-vision-image-label:18.0.5"
10093
}
10194

10295
clean.doLast {

smoke-tests/src/main/java/com/google/firebase/testing/BuildOnlyTest.java

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -19,19 +19,20 @@
1919
import com.google.firebase.appindexing.FirebaseAppIndex;
2020
import com.google.firebase.inappmessaging.FirebaseInAppMessaging;
2121
// import com.google.firebase.messaging.FirebaseMessaging;
22-
// import com.google.firebase.perf.FirebasePerformance;
23-
import com.google.firebase.ml.vision.FirebaseVision;
22+
import com.google.firebase.perf.FirebasePerformance;
2423
import org.junit.Test;
2524
import org.junit.runner.RunWith;
2625
import org.junit.runners.JUnit4;
2726

27+
import static androidx.test.core.app.ApplicationProvider.getApplicationContext;
28+
2829
/** Contains initialization test cases for build-only libraries. */
2930
@RunWith(JUnit4.class)
3031
public final class BuildOnlyTest {
3132

3233
@Test
3334
public void appindexing_IsNotNull() {
34-
assertThat(FirebaseAppIndex.getInstance()).isNotNull();
35+
assertThat(FirebaseAppIndex.getInstance(getApplicationContext())).isNotNull();
3536
}
3637

3738
@Test
@@ -42,15 +43,10 @@ public void inappmessaging_IsNotNull() {
4243
// @Test
4344
// public void messaging_IsNotNull() {
4445
// assertThat(FirebaseMessaging.getInstance()).isNotNull();
45-
// }
46-
47-
// @Test
48-
// public void performance_IsNotNull() {
49-
// assertThat(FirebasePerformance.getInstance()).isNotNull();
5046
// }
5147

5248
@Test
53-
public void vision_IsNotNull() {
54-
assertThat(FirebaseVision.getInstance()).isNotNull();
49+
public void performance_IsNotNull() {
50+
assertThat(FirebasePerformance.getInstance()).isNotNull();
5551
}
5652
}

0 commit comments

Comments
 (0)