Skip to content

Commit 36f41bc

Browse files
committed
upload even if error
1 parent d92145b commit 36f41bc

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

ci/fireci/fireciplugins/macrobenchmark/commands.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,11 @@ def ci(pull_request, repeat):
145145
# TODO(yifany): run tests only for affected product in pull requests
146146

147147
output_path = Path("macrobenchmark-test-output.json")
148-
asyncio.run(runner.start(build_only=False, local=False, repeat=repeat, output=output_path))
148+
exception = None
149+
try:
150+
asyncio.run(runner.start(build_only=False, local=False, repeat=repeat, output=output_path))
151+
except Exception as e:
152+
exception = e
149153

150154
with open(output_path) as output_file:
151155
output = json.load(output_file)
@@ -160,5 +164,7 @@ def ci(pull_request, repeat):
160164
access_token = ci_utils.gcloud_identity_token()
161165
uploader.post_report(startup_time_data, metric_service_url, access_token, 'startup-time')
162166

167+
if exception:
168+
raise exception
163169

164170
# TODO(yifany): support of command chaining

0 commit comments

Comments
 (0)