Skip to content

Commit 3fdff9f

Browse files
committed
Remove Converter.
1 parent ffb9786 commit 3fdff9f

File tree

2 files changed

+9
-13
lines changed

2 files changed

+9
-13
lines changed

firebase-config/firebase-config.gradle

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,6 @@ dependencies {
5757

5858
implementation 'com.google.firebase:firebase-measurement-connector:18.0.0'
5959
implementation 'com.google.android.gms:play-services-tasks:17.0.2'
60-
implementation 'com.google.guava:guava:28.1-android'
6160

6261
compileOnly 'com.google.code.findbugs:jsr305:3.0.2'
6362

firebase-config/src/main/java/com/google/firebase/remoteconfig/internal/Personalization.java

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@
1616

1717
import android.os.Bundle;
1818
import androidx.annotation.NonNull;
19-
import com.google.common.base.CaseFormat;
20-
import com.google.common.base.Converter;
2119
import com.google.firebase.analytics.connector.AnalyticsConnector;
2220
import java.util.Collections;
2321
import java.util.HashMap;
@@ -27,20 +25,19 @@
2725
public class Personalization {
2826
public static final String ANALYTICS_ORIGIN_PERSONALIZATION = "fp";
2927

30-
public static final String ANALYTICS_PULL_EVENT = "personalization_choice";
28+
public static final String ANALYTICS_PULL_EVENT = "personalization_assignment";
3129
public static final String ARM_KEY = "arm_key";
3230
public static final String ARM_VALUE = "arm_value";
33-
public static final String PERSONALIZATION_ID = "personalization_id";
34-
public static final String ARM_INDEX = "arm_index";
31+
public static final String PERSONALIZATION_ID = "personalizationId";
32+
public static final String PERSONALIZATION_ID_KEY = "personalization_id";
33+
public static final String ARM_INDEX = "armIndex";
34+
public static final String ARM_INDEX_KEY = "arm_index";
3535
public static final String GROUP = "group";
3636

3737
public static final String ANALYTICS_PULL_EVENT_INTERNAL = "_fpc";
3838
public static final String CHOICE_ID = "choiceId";
3939
public static final String CHOICE_ID_KEY = "_fpid";
4040

41-
private static final Converter<String, String> CONVERTER =
42-
CaseFormat.LOWER_UNDERSCORE.converterTo(CaseFormat.LOWER_CAMEL);
43-
4441
/** The app's Firebase Analytics client. */
4542
private final AnalyticsConnector analyticsConnector;
4643

@@ -77,7 +74,7 @@ public void logArmActive(@NonNull String key, @NonNull ConfigContainer configCon
7774
return;
7875
}
7976

80-
String personalizationId = metadata.optString(CONVERTER.convert(PERSONALIZATION_ID));
77+
String personalizationId = metadata.optString(PERSONALIZATION_ID);
8178
if (personalizationId.isEmpty()) {
8279
return;
8380
}
@@ -92,9 +89,9 @@ public void logArmActive(@NonNull String key, @NonNull ConfigContainer configCon
9289
Bundle params = new Bundle();
9390
params.putString(ARM_KEY, key);
9491
params.putString(ARM_VALUE, values.optString(key));
95-
params.putString(PERSONALIZATION_ID, personalizationId);
96-
params.putInt(ARM_INDEX, metadata.optInt(CONVERTER.convert(ARM_INDEX), -1));
97-
params.putString(GROUP, metadata.optString(CONVERTER.convert(GROUP)));
92+
params.putString(PERSONALIZATION_ID_KEY, personalizationId);
93+
params.putInt(ARM_INDEX_KEY, metadata.optInt(ARM_INDEX, -1));
94+
params.putString(GROUP, metadata.optString(GROUP));
9895
analyticsConnector.logEvent(ANALYTICS_ORIGIN_PERSONALIZATION, ANALYTICS_PULL_EVENT, params);
9996

10097
Bundle paramsInternal = new Bundle();

0 commit comments

Comments
 (0)