Skip to content

Commit 4122bc7

Browse files
committed
Address review comments.
1 parent 3acfaee commit 4122bc7

File tree

1 file changed

+5
-9
lines changed

1 file changed

+5
-9
lines changed

firebase-abt/src/main/java/com/google/firebase/abt/FirebaseABTesting.java

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -334,10 +334,7 @@ private static List<AbtExperimentInfo> convertMapsToExperimentInfos(
334334
}
335335

336336
private void addExperimentToAnalytics(ConditionalUserProperty experiment) {
337-
AnalyticsConnector connector = this.analyticsConnector.get();
338-
if (connector != null) {
339-
connector.setConditionalUserProperty(experiment);
340-
}
337+
analyticsConnector.get().setConditionalUserProperty(experiment);
341338
}
342339

343340
private void throwAbtExceptionIfAnalyticsIsNull() throws AbtException {
@@ -354,11 +351,10 @@ private void throwAbtExceptionIfAnalyticsIsNull() throws AbtException {
354351
* breaking, or if the underlying Analytics clear method is failing.
355352
*/
356353
private void removeExperimentFromAnalytics(String experimentId) {
357-
AnalyticsConnector connector = this.analyticsConnector.get();
358-
if (connector != null) {
359-
connector.clearConditionalUserProperty(
360-
experimentId, /*clearEventName=*/ null, /*clearEventParams=*/ null);
361-
}
354+
analyticsConnector
355+
.get()
356+
.clearConditionalUserProperty(
357+
experimentId, /*clearEventName=*/ null, /*clearEventParams=*/ null);
362358
}
363359

364360
@WorkerThread

0 commit comments

Comments
 (0)