Skip to content

Commit 41715ed

Browse files
Speed up SpecTest (#2969)
1 parent 67f91ad commit 41715ed

File tree

2 files changed

+27
-3
lines changed

2 files changed

+27
-3
lines changed

firebase-firestore/src/main/java/com/google/firebase/firestore/remote/Datastore.java

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -92,10 +92,19 @@ public Datastore(
9292
this.databaseInfo = databaseInfo;
9393
this.workerQueue = workerQueue;
9494
this.serializer = new RemoteSerializer(databaseInfo.getDatabaseId());
95+
this.channel =
96+
initializeChannel(
97+
databaseInfo, workerQueue, credentialsProvider, context, metadataProvider);
98+
}
9599

96-
channel =
97-
new FirestoreChannel(
98-
workerQueue, context, credentialsProvider, databaseInfo, metadataProvider);
100+
FirestoreChannel initializeChannel(
101+
DatabaseInfo databaseInfo,
102+
AsyncQueue workerQueue,
103+
CredentialsProvider credentialsProvider,
104+
Context context,
105+
@Nullable GrpcMetadataProvider metadataProvider) {
106+
return new FirestoreChannel(
107+
workerQueue, context, credentialsProvider, databaseInfo, metadataProvider);
99108
}
100109

101110
void shutdown() {

firebase-firestore/src/test/java/com/google/firebase/firestore/remote/MockDatastore.java

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@
1717
import static com.google.firebase.firestore.util.Assert.hardAssert;
1818

1919
import android.content.Context;
20+
import androidx.annotation.Nullable;
21+
import com.google.firebase.firestore.auth.CredentialsProvider;
2022
import com.google.firebase.firestore.core.DatabaseInfo;
2123
import com.google.firebase.firestore.local.TargetData;
2224
import com.google.firebase.firestore.model.SnapshotVersion;
@@ -218,6 +220,19 @@ public MockDatastore(DatabaseInfo databaseInfo, AsyncQueue workerQueue, Context
218220
this.serializer = new RemoteSerializer(getDatabaseInfo().getDatabaseId());
219221
}
220222

223+
@Override
224+
FirestoreChannel initializeChannel(
225+
DatabaseInfo databaseInfo,
226+
AsyncQueue workerQueue,
227+
CredentialsProvider credentialsProvider,
228+
Context context,
229+
@Nullable GrpcMetadataProvider metadataProvider) {
230+
return null;
231+
}
232+
233+
@Override
234+
void shutdown() {}
235+
221236
@Override
222237
WatchStream createWatchStream(WatchStream.Callback listener) {
223238
watchStream = new MockWatchStream(getWorkerQueue(), listener);

0 commit comments

Comments
 (0)