Skip to content

Commit 42cfc53

Browse files
committed
Address reviewer comments
1 parent f639b71 commit 42cfc53

File tree

1 file changed

+8
-11
lines changed

1 file changed

+8
-11
lines changed

firebase-firestore/firebase-firestore.gradle

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -66,18 +66,15 @@ android {
6666
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
6767
consumerProguardFiles 'proguard.txt'
6868

69-
if (findProperty("useProdBackendForTests")) {
70-
buildConfigField("boolean", "USE_EMULATOR_FOR_TESTS", "false")
71-
} else {
72-
buildConfigField("boolean", "USE_EMULATOR_FOR_TESTS", "true")
73-
}
69+
buildConfigField(
70+
"boolean",
71+
"USE_EMULATOR_FOR_TESTS",
72+
findProperty("useProdBackendForTests").asBoolean().toString()
73+
)
74+
75+
def targetBackend = findProperty("targetBackend") ?: "emulator"
76+
buildConfigField("String", "TARGET_BACKEND", "\"$targetBackend\"")
7477

75-
if (hasProperty('targetBackend')) {
76-
buildConfigField("String", "TARGET_BACKEND", "\"${property("targetBackend")}\"")
77-
} else {
78-
// By default set the target backend to 'emulator'
79-
buildConfigField("String", "TARGET_BACKEND", "\"emulator\"")
80-
}
8178
def localProps = new Properties()
8279

8380
try {

0 commit comments

Comments
 (0)