Skip to content

Commit 449ecc0

Browse files
committed
long name test
1 parent b4fc4e8 commit 449ecc0

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

firebase-perf/src/test/java/com/google/firebase/perf/application/FragmentStateMonitorTest.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ public void lifecycleCallbacks_cleansUpMap_duringActivityTransitions() {
133133
}
134134

135135
@Test
136-
public void fragmentTraceCreation_truncatesName_whenFragmentNameTooLong() {
136+
public void fragmentTraceCreation_dropsTrace_whenFragmentNameTooLong() {
137137
AppStateMonitor appStateMonitor =
138138
spy(new AppStateMonitor(mockTransportManager, clock, configResolver, fma));
139139
FragmentStateMonitor fragmentMonitor =
@@ -144,7 +144,9 @@ public void fragmentTraceCreation_truncatesName_whenFragmentNameTooLong() {
144144
.getFragmentScreenTraceName(nullable(Fragment.class));
145145

146146
fragmentMonitor.onFragmentResumed(mockFragmentManager, mockFragment);
147+
verify(mockTransportManager, times(0)).log(any(TraceMetric.class), any());
147148
fragmentMonitor.onFragmentPaused(mockFragmentManager, mockFragment);
149+
verify(mockTransportManager, times(0)).log(any(TraceMetric.class), any());
148150
}
149151

150152
/************ FrameMetrics Collection Tests ****************/
@@ -164,10 +166,13 @@ public void onFragmentPaused_processFrameMetrics_beforeReset() {
164166
appStateMonitor.onActivityPaused(mockActivity);
165167
// reset() was not called at the time of fragments collecting its frame metrics
166168
verify(fma, times(0)).reset();
169+
verify(fma, times(0)).remove(nullable(Activity.class));
167170
fragmentMonitor.onFragmentPaused(mockFragmentManager, mockFragment);
168171
verify(fma, times(0)).reset();
172+
verify(fma, times(0)).remove(nullable(Activity.class));
169173
// reset() is only called after fragment is done collecting its metrics
170174
appStateMonitor.onActivityPostPaused(mockActivity);
171175
verify(fma, times(1)).reset();
176+
verify(fma, times(1)).remove(nullable(Activity.class));
172177
}
173178
}

0 commit comments

Comments
 (0)