Skip to content

Commit 4850b06

Browse files
Improve testIgnoresTargetMappingAfterExistenceFilterMismatch (#3306)
1 parent 9cd2475 commit 4850b06

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

firebase-firestore/src/test/java/com/google/firebase/firestore/local/LocalStoreTestCase.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1155,7 +1155,7 @@ public void testIgnoresTargetMappingAfterExistenceFilterMismatch() {
11551155

11561156
// Create an existence filter mismatch and verify that the last limbo free snapshot version
11571157
// is deleted
1158-
applyRemoteEvent(existenceFilterEvent(targetId, 2, 20));
1158+
applyRemoteEvent(existenceFilterEvent(targetId, keySet(key("foo/a")), 2, 20));
11591159
cachedTargetData = localStore.getTargetData(query.toTarget());
11601160
Assert.assertEquals(version(0), cachedTargetData.getLastLimboFreeSnapshotVersion());
11611161
Assert.assertEquals(ByteString.EMPTY, cachedTargetData.getResumeToken());

firebase-firestore/src/testUtil/java/com/google/firebase/firestore/testutil/TestUtil.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -427,12 +427,13 @@ public static RemoteEvent addedRemoteEvent(
427427
return addedRemoteEvent(singletonList(doc), updatedInTargets, removedFromTargets, null);
428428
}
429429

430-
public static RemoteEvent existenceFilterEvent(int targetId, int count, int version) {
430+
public static RemoteEvent existenceFilterEvent(
431+
int targetId, ImmutableSortedSet<DocumentKey> syncedKeys, int remoteCount, int version) {
431432
TargetData targetData = TestUtil.targetData(targetId, QueryPurpose.LISTEN, "foo");
432433
TestTargetMetadataProvider testTargetMetadataProvider = new TestTargetMetadataProvider();
433-
testTargetMetadataProvider.setSyncedKeys(targetData, DocumentKey.emptyKeySet());
434+
testTargetMetadataProvider.setSyncedKeys(targetData, syncedKeys);
434435

435-
ExistenceFilter existenceFilter = new ExistenceFilter(count);
436+
ExistenceFilter existenceFilter = new ExistenceFilter(remoteCount);
436437
WatchChangeAggregator aggregator = new WatchChangeAggregator(testTargetMetadataProvider);
437438

438439
WatchChange.ExistenceFilterWatchChange existenceFilterWatchChange =

0 commit comments

Comments
 (0)