Skip to content

Commit 488a8a4

Browse files
committed
review
1 parent ee1fa0d commit 488a8a4

File tree

4 files changed

+8
-2
lines changed

4 files changed

+8
-2
lines changed

firebase-perf/CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ Refer [GMaven](https://maven.google.com/web/index.html?q=firebase-perf#com.googl
2222
## Unreleased
2323

2424
* {{fixed}} Fixed a bug where screen traces were not capturing frame metrics for multi-activity apps.
25-
* {{feature}} Add support for out-of-the-box Fragment screen performance measurement.
25+
* {{feature}} Added support for measuring screen performance metrics for "Activity Fragments" out-of-the-box.
2626

2727
## Released
2828

firebase-perf/dev-app/src/main/AndroidManifest.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,9 @@
3535
<meta-data
3636
android:name="sessions_sampling_percentage"
3737
android:value="100.0" />
38+
<meta-data
39+
android:name="fragment_sampling_percentage"
40+
android:value="100.0" />
3841

3942
<receiver
4043
android:name=".FirebasePerfTestReceiver"

firebase-perf/e2e-app/src/main/AndroidManifest.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,9 @@
3333
<meta-data
3434
android:name="sessions_sampling_percentage"
3535
android:value="100.0" />
36+
<meta-data
37+
android:name="fragment_sampling_percentage"
38+
android:value="100.0" />
3639
</application>
3740

3841
</manifest>

firebase-perf/src/main/java/com/google/firebase/perf/config/ConfigurationConstants.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -640,7 +640,7 @@ protected static synchronized FragmentSamplingRate getInstance() {
640640

641641
@Override
642642
protected Float getDefault() {
643-
// Sampling rate range is [0.00f, 1.00f]. By default, sampling rate is 1.00f, which is 100%.
643+
// Sampling rate range is [0.00f, 1.00f]. By default, sampling rate is 0.00f, which is 0%.
644644
// 0.00f means 0%, Fireperf will not capture any event for fragment trace from the device,
645645
// 1.00f means 100%, Fireperf will capture all events for fragment trace from the device.
646646
return 0.00f;

0 commit comments

Comments
 (0)