Skip to content

Commit 497434f

Browse files
committed
Add TestUtil.fieldMask(String...) to simplify creating FieldMasks.
1 parent 4d88c95 commit 497434f

File tree

3 files changed

+13
-3
lines changed

3 files changed

+13
-3
lines changed

firebase-firestore/src/test/java/com/google/firebase/firestore/local/LocalSerializerTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
import static com.google.firebase.firestore.testutil.TestUtil.deletedDoc;
1919
import static com.google.firebase.firestore.testutil.TestUtil.doc;
2020
import static com.google.firebase.firestore.testutil.TestUtil.field;
21+
import static com.google.firebase.firestore.testutil.TestUtil.fieldMask;
2122
import static com.google.firebase.firestore.testutil.TestUtil.key;
2223
import static com.google.firebase.firestore.testutil.TestUtil.map;
2324
import static com.google.firebase.firestore.testutil.TestUtil.setMutation;
@@ -44,7 +45,6 @@
4445
import com.google.firestore.v1beta1.Value;
4546
import com.google.firestore.v1beta1.Write;
4647
import com.google.protobuf.ByteString;
47-
import java.util.HashSet;
4848
import org.junit.Before;
4949
import org.junit.Test;
5050
import org.junit.runner.RunWith;
@@ -72,7 +72,7 @@ public void testEncodesMutationBatch() {
7272
new PatchMutation(
7373
key("bar/baz"),
7474
TestUtil.wrapObject(map("a", "b", "num", 1)),
75-
FieldMask.fromSet(new HashSet<>(asList(field("a")))),
75+
fieldMask("a"),
7676
com.google.firebase.firestore.model.mutation.Precondition.exists(true));
7777
Mutation del = deleteMutation("baz/quux");
7878
Timestamp writeTime = Timestamp.now();

firebase-firestore/src/test/java/com/google/firebase/firestore/model/MutationTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
import static com.google.firebase.firestore.testutil.TestUtil.deletedDoc;
1919
import static com.google.firebase.firestore.testutil.TestUtil.doc;
2020
import static com.google.firebase.firestore.testutil.TestUtil.field;
21+
import static com.google.firebase.firestore.testutil.TestUtil.fieldMask;
2122
import static com.google.firebase.firestore.testutil.TestUtil.key;
2223
import static com.google.firebase.firestore.testutil.TestUtil.map;
2324
import static com.google.firebase.firestore.testutil.TestUtil.mutationResult;
@@ -111,7 +112,7 @@ public void testDeletesValuesFromTheFieldMask() {
111112
Document baseDoc = doc("collection/key", 0, data);
112113

113114
DocumentKey key = key("collection/key");
114-
FieldMask mask = FieldMask.fromSet(new HashSet<>(Arrays.asList(field("foo.bar"))));
115+
FieldMask mask = fieldMask("foo.bar");
115116
Mutation patch = new PatchMutation(key, ObjectValue.emptyObject(), mask, Precondition.NONE);
116117

117118
MaybeDocument patchDoc = patch.applyToLocalView(baseDoc, baseDoc, Timestamp.now());

firebase-firestore/src/testUtil/java/com/google/firebase/firestore/testutil/TestUtil.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,7 @@
7474
import java.util.Collections;
7575
import java.util.Comparator;
7676
import java.util.HashMap;
77+
import java.util.HashSet;
7778
import java.util.List;
7879
import java.util.Map;
7980
import java.util.Map.Entry;
@@ -111,6 +112,14 @@ public static ByteString byteString(int... bytes) {
111112
return ByteString.copyFrom(primitive);
112113
}
113114

115+
public static FieldMask fieldMask(String... fields) {
116+
FieldPath[] mask = new FieldPath[fields.length];
117+
for (int i = 0; i < fields.length; i++) {
118+
mask[i] = field(fields[i]);
119+
}
120+
return FieldMask.fromSet(new HashSet<>(Arrays.asList(mask)));
121+
}
122+
114123
public static final Map<String, Object> EMPTY_MAP = new HashMap<>();
115124

116125
public static FieldValue wrap(Object value) {

0 commit comments

Comments
 (0)