Skip to content

Commit 4981a22

Browse files
committed
Simplify the null check
1 parent d0da463 commit 4981a22

File tree

1 file changed

+1
-11
lines changed

1 file changed

+1
-11
lines changed

firebase-sessions/src/main/kotlin/com/google/firebase/sessions/SessionEvents.kt

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616

1717
package com.google.firebase.sessions
1818

19-
import android.content.pm.PackageInfo
2019
import android.os.Build
2120
import com.google.firebase.FirebaseApp
2221
import com.google.firebase.encoders.DataEncoder
@@ -76,19 +75,10 @@ internal object SessionEvents {
7675
androidAppInfo =
7776
AndroidApplicationInfo(
7877
packageName = packageName,
79-
versionName = versionName(packageInfo) ?: buildVersion,
78+
versionName = packageInfo.versionName ?: buildVersion,
8079
appBuildVersion = buildVersion,
8180
deviceManufacturer = Build.MANUFACTURER,
8281
)
8382
)
8483
}
85-
86-
private fun versionName(packageInfo: PackageInfo): String? =
87-
try {
88-
packageInfo.versionName
89-
} catch (_: NullPointerException) {
90-
// https://github.com/firebase/firebase-android-sdk/issues/5195#issuecomment-1651834306
91-
// packageInfo.versionName has type String! but returns null when unset.
92-
null
93-
}
9484
}

0 commit comments

Comments
 (0)