Skip to content

Commit 4fa77b2

Browse files
authored
Update apksize InAppMessaging test app to use OSS code. (#793)
1 parent a011927 commit 4fa77b2

File tree

2 files changed

+18
-14
lines changed

2 files changed

+18
-14
lines changed

tools/measurement/apksize/src/inappmessagingdisplay/inappmessaging-display.gradle

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,8 @@ android {
2929
}
3030
}
3131
dependencies {
32-
inappmessagingdisplayImplementation ("com.google.firebase:firebase-inappmessaging-display:19.0.0") {
33-
exclude group: "com.google.firebase", module: "firebase-common"
34-
}
35-
inappmessagingdisplayImplementation ("com.google.firebase:firebase-inappmessaging:19.0.0") {
36-
exclude group: "com.google.firebase", module: "firebase-common"
37-
}
32+
inappmessagingdisplayImplementation project(":firebase-inappmessaging-display")
33+
inappmessagingdisplayImplementation project(":firebase-inappmessaging")
34+
35+
inappmessagingdisplayImplementation "com.google.android.gms:play-services-base:17.0.0"
3836
}

tools/measurement/apksize/src/inappmessagingdisplay/java/com.google.apksize/InAppMessagingDisplay.java

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,19 @@
1919
import com.google.android.gms.tasks.Task;
2020
import com.google.android.gms.tasks.TaskCompletionSource;
2121
import com.google.firebase.inappmessaging.FirebaseInAppMessagingDisplayCallbacks;
22+
import com.google.firebase.inappmessaging.model.Action;
23+
import com.google.firebase.inappmessaging.model.CampaignMetadata;
24+
import com.google.firebase.inappmessaging.model.ModalMessage;
25+
import com.google.firebase.inappmessaging.model.Text;
2226
import com.google.firebase.inappmessaging.display.FirebaseInAppMessagingDisplay;
27+
import androidx.annotation.NonNull;
2328
import com.google.firebase.inappmessaging.model.InAppMessage;
2429

2530
public class InAppMessagingDisplay implements SampleCode {
2631
private static final String SAMPLE_TEXT = "My sample text";
2732
private static final String ACTION_URL = "https://www.example.com";
2833
private static final String CAMPAIGN_ID = "my_campaign";
34+
private static final String CAMPAIGN_NAME = "my_campaign_name";
2935
private static final String TITLE = "Title";
3036

3137
public static class DisplayCallback implements FirebaseInAppMessagingDisplayCallbacks {
@@ -40,25 +46,25 @@ public Task<Void> messageDismissed(InAppMessagingDismissType dismissType) {
4046
}
4147

4248
@Override
43-
public Task<Void> messageClicked() {
49+
public Task<Void> displayErrorEncountered(InAppMessagingErrorReason inAppMessagingErrorReason) {
4450
return new TaskCompletionSource<Void>().getTask();
4551
}
4652

4753
@Override
48-
public Task<Void> displayErrorEncountered(InAppMessagingErrorReason InAppMessagingErrorReason) {
54+
public Task<Void> messageClicked(@NonNull Action action) {
4955
return new TaskCompletionSource<Void>().getTask();
5056
}
5157
}
5258

5359
@Override
5460
public void runSample(Context context) {
61+
CampaignMetadata metadata = new CampaignMetadata(CAMPAIGN_ID, CAMPAIGN_NAME, true);
5562
InAppMessage message =
56-
InAppMessage.builder()
57-
.setBody(InAppMessage.Text.builder().setText(SAMPLE_TEXT).build())
58-
.setAction(InAppMessage.Action.builder().setActionUrl(ACTION_URL).build())
59-
.setCampaignId(CAMPAIGN_ID)
60-
.setTitle(InAppMessage.Text.builder().setText(TITLE).build())
61-
.build();
63+
ModalMessage.builder()
64+
.setBody(Text.builder().setText(SAMPLE_TEXT).build())
65+
.setAction(Action.builder().setActionUrl(ACTION_URL).build())
66+
.setTitle(Text.builder().setText(TITLE).build())
67+
.build(metadata);
6268

6369
// NOTE: Context is *not guaranteed* to be an Activity. This is **fine** in this case because we
6470
// only want to compile the APK to measure it size, and it will not be run.

0 commit comments

Comments
 (0)