Skip to content

Commit 50035be

Browse files
committed
Make constructors non-private.
This removes an extra synthetic class that is otherwise generated to allow the Builder to create its parent class and vice versa.
1 parent c863d96 commit 50035be

File tree

1 file changed

+2
-2
lines changed
  • encoders/protoc-gen-firebase-encoders/src/main/kotlin/com/google/firebase/encoders/proto/codegen

1 file changed

+2
-2
lines changed

encoders/protoc-gen-firebase-encoders/src/main/kotlin/com/google/firebase/encoders/proto/codegen/CodeGenerator.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -246,7 +246,7 @@ internal class Gen(
246246
}
247247
val messageTypeName = ClassName.bestGuess(type.name)
248248

249-
val constructor = MethodSpec.constructorBuilder().addModifiers(Modifier.PRIVATE)
249+
val constructor = MethodSpec.constructorBuilder()
250250
messageClass.addMethod(MethodSpec.methodBuilder("newBuilder")
251251
.addModifiers(Modifier.PUBLIC, Modifier.STATIC)
252252
.returns(ClassName.bestGuess("Builder"))
@@ -351,7 +351,7 @@ internal class Gen(
351351
.addCode("return new \$T(\$L);\n", messageTypeName, buildMethodArgs)
352352
.build())
353353

354-
val builderConstructor = MethodSpec.constructorBuilder().addModifiers(Modifier.PRIVATE)
354+
val builderConstructor = MethodSpec.constructorBuilder()
355355

356356
for (field in type.fields) {
357357
builder.addField(FieldSpec.builder(field.typeName, "${field.name}_", Modifier.PRIVATE).build())

0 commit comments

Comments
 (0)