Wrap SDK name with double quotes as a name can contain a colon. (#887)

yifanyang · web-flow · commit 508bddcdf527 · 2019-10-08T16:08:39.000-07:00
AAR sizes are uploaded to database via a JSON file. The SDK names (that contains colon characters) were not properly quoted, which made the JSON file invalid. This commit fixes it.
diff --git a/buildSrc/src/main/groovy/com/google/firebase/gradle/plugins/measurement/aarsize/AarSizeJsonBuilder.groovy b/buildSrc/src/main/groovy/com/google/firebase/gradle/plugins/measurement/aarsize/AarSizeJsonBuilder.groovy
@@ -43,7 +43,7 @@ class AarSizeJsonBuilder {
         }
 
         def sizes = sdkAarSizes.collect {
-            "[$pullRequestNumber, $it.first, $it.second]"
+            "[$pullRequestNumber, \"$it.first\", $it.second]"
         }.join(", ")
 
         def json = """

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ class AarSizeJsonBuilder {`
`43`	`43`	`}`
`44`	`44`
`45`	`45`	`def sizes = sdkAarSizes.collect {`
`46`		`- "[$pullRequestNumber, $it.first, $it.second]"`
	`46`	`+ "[$pullRequestNumber, \"$it.first\", $it.second]"`
`47`	`47`	`}.join(", ")`
`48`	`48`
`49`	`49`	`def json = """`