Add feedback button to app-distribution/test-app (#3924)

Author: lfkellogg

build.gradle

@@ -37,6 +37,7 @@ buildscript {
         classpath 'digital.wup:android-maven-publish:3.6.3'
         classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlinVersion"
         classpath 'org.jlleitschuh.gradle:ktlint-gradle:9.2.1'
+        classpath 'com.google.firebase:firebase-appdistribution-gradle:3.0.2'
     }
 }
 

firebase-appdistribution/test-app/README.md

@@ -47,4 +47,28 @@ and install the apk:
 
 ```
 firebase-android-sdk$ adb install firebase-appdistribution/test-app/build/outputs/apk/release/test-app-release.apk
-```
+```
+
+## Test In-App Feedback Locally
+
+In-App Feedback is currently tricky to test locally because it relies on the
+fact that a release exists with the same hash of the running binary.
+
+To build the debug APK, upload it to App Distribution, and install it on the running emulator:
+1. Start an emulator
+2. Run the following command from the repo's root directory:
+
+    ```
+    ./gradlew :firebase-appdistribution:test-app:build :firebase-appdistribution:test-app:appDistributionUploadDebug && adb install firebase-appdistribution/test-app/build/outputs/apk/debug/test-app-debug.apk
+   ```
+
+After that, if you want to avoid having to do this every time you want to test
+locally:
+
+1. Submit feedback in the locally running app, to generate some logs
+2. In the Logcat output, find the release name (i.e. "projects/1095562444941/installations/fCmpB677QTybkwfKbViGI-/releases/3prs96fui9kb0")
+3. Modify the body of `ReleaseIdentifier.identifyRelease()` to be:
+
+    ```
+    return Tasks.forResult("<your release name>");
+   ```

firebase-appdistribution/test-app/src/main/java/com/googletest/firebase/appdistribution/testapp/MainActivity.kt

@@ -13,6 +13,7 @@ import androidx.appcompat.widget.AppCompatButton
 import com.google.android.gms.tasks.Task
 import com.google.firebase.appdistribution.AppDistributionRelease
 import com.google.firebase.appdistribution.FirebaseAppDistribution
+import com.google.firebase.appdistribution.FirebaseAppDistributionException
 import com.google.firebase.appdistribution.UpdateProgress
 import java.util.concurrent.ExecutorService
 import java.util.concurrent.Executors
@@ -32,6 +33,7 @@ class MainActivity : AppCompatActivity() {
     lateinit var signOutButtonBackground: AppCompatButton
     lateinit var checkForUpdateButtonBackground: AppCompatButton
     lateinit var updateAppButtonBackground: AppCompatButton
+    lateinit var feedbackButton: AppCompatButton
     lateinit var progressPercentage: TextView
     lateinit var signInStatus: TextView
     lateinit var progressPercent: TextView
@@ -51,6 +53,7 @@ class MainActivity : AppCompatActivity() {
         signOutButtonBackground = findViewById<AppCompatButton>(R.id.sign_out2)
         checkForUpdateButtonBackground = findViewById<AppCompatButton>(R.id.check_for_update2)
         updateAppButtonBackground = findViewById<AppCompatButton>(R.id.update_app2)
+        feedbackButton = findViewById<AppCompatButton>(R.id.feedbackButton)
         progressPercentage = findViewById<TextView>(R.id.progress_percentage)
         signInStatus = findViewById<TextView>(R.id.sign_in_status)
         progressPercent = findViewById<TextView>(R.id.progress_percentage)
@@ -164,6 +167,10 @@ class MainActivity : AppCompatActivity() {
                 firebaseAppDistribution.updateApp().addOnProgressListener { progressListener(it) }
             }
         }
+
+        feedbackButton.setOnClickListener {
+            firebaseAppDistribution.collectAndSendFeedback()
+        }
     }
 
     fun startSecondActivity() {

firebase-appdistribution/test-app/src/main/res/layout/activity_main.xml

@@ -179,5 +179,14 @@
         app:layout_constraintLeft_toLeftOf="parent"
         app:layout_constraintRight_toRightOf="parent"
         app:layout_constraintTop_toBottomOf="@id/progress_percentage" />
+    <Button
+        android:id="@+id/feedbackButton"
+        android:layout_width="wrap_content"
+        android:layout_height="wrap_content"
+        android:layout_marginTop="20dp"
+        android:text="Send feedback"
+        app:layout_constraintEnd_toEndOf="parent"
+        app:layout_constraintStart_toStartOf="parent"
+        app:layout_constraintTop_toBottomOf="@+id/sign_out" />
 
 </androidx.constraintlayout.widget.ConstraintLayout>

firebase-appdistribution/test-app/test-app.gradle

@@ -15,6 +15,7 @@ plugins {
     id 'com.android.application'
     id 'kotlin-android'
     id 'com.google.gms.google-services'
+    id 'com.google.firebase.appdistribution'
 }
 
 android {
@@ -31,11 +32,18 @@ android {
     }
 
     buildTypes {
-        // This is so we can build the "release" variant for the "dev-app" (and the SDK) without
-        // needing to have the app signed.
         release {
+            // This is so we can build the "release" variant for the "dev-app" (and the SDK) without
+            // needing to have the app signed.
             initWith debug
         }
+
+        debug {
+            firebaseAppDistribution {
+                releaseNotes "Debug variant of Android SDK test app"
+                // testers "your email here"
+            }
+        }
     }
     compileOptions {
         sourceCompatibility JavaVersion.VERSION_1_8
@@ -50,13 +58,11 @@ dependencies {
     // TODO(rachelprince): Add flag to build with public version of SDK
     println("Building with HEAD version ':firebase-appdistribution' of SDK")
 
-    // Debug variant uses full SDK
-    debugImplementation project(':firebase-appdistribution-api') // TODO(lkellogg): why doesn't this get picked up transitively?
+    // Include the API in all variants
+    implementation project(':firebase-appdistribution-api')
+    // Only include the full SDK implementation in the debug variant
     debugImplementation project(':firebase-appdistribution')
 
-    // Release variant just uses the API, as if publishing to Play
-    releaseImplementation project(':firebase-appdistribution-api')
-
     implementation "com.google.android.gms:play-services-tasks:18.0.1"
 
     implementation "org.jetbrains.kotlin:kotlin-stdlib:$kotlinVersion"