Skip to content

Commit 5af4621

Browse files
authored
libs.versions.toml: add ThreeTenAbp (backport of java.time for Android) (#6416)
1 parent 0697dd3 commit 5af4621

File tree

3 files changed

+11
-0
lines changed

3 files changed

+11
-0
lines changed

firebase-dataconnect/connectors/connectors.gradle.kts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,8 @@ dependencies {
7070

7171
testImplementation(project(":firebase-dataconnect:testutil"))
7272
testImplementation(libs.androidx.test.junit)
73+
testImplementation(libs.kotest.assertions)
74+
testImplementation(libs.kotest.property)
7375
testImplementation(libs.kotlin.coroutines.test)
7476
testImplementation(libs.mockk)
7577
testImplementation(libs.robolectric)
@@ -84,6 +86,7 @@ dependencies {
8486
androidTestImplementation(libs.kotest.assertions)
8587
androidTestImplementation(libs.kotest.property)
8688
androidTestImplementation(libs.kotlin.coroutines.test)
89+
androidTestImplementation(libs.testonly.three.ten.abp)
8790
androidTestImplementation(libs.truth)
8891
androidTestImplementation(libs.truth.liteproto.extension)
8992
androidTestImplementation(libs.turbine)

firebase-dataconnect/testutil/testutil.gradle.kts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,13 +55,15 @@ dependencies {
5555
implementation("com.google.firebase:firebase-auth:22.3.1")
5656

5757
implementation(libs.androidx.test.junit)
58+
implementation(libs.kotest.assertions)
5859
implementation(libs.kotest.property)
5960
implementation(libs.kotlin.coroutines.test)
6061
implementation(libs.kotlinx.coroutines.core)
6162
implementation(libs.kotlinx.serialization.core)
6263
implementation(libs.mockk)
6364
implementation(libs.protobuf.java.lite)
6465
implementation(libs.robolectric)
66+
implementation(libs.testonly.three.ten.abp)
6567
implementation(libs.truth)
6668
}
6769

gradle/libs.versions.toml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,12 @@ quickcheck = { module = "net.java:quickcheck", version.ref = "quickcheck" }
9494
spotless-plugin-gradle = { module = "com.diffplug.spotless:spotless-plugin-gradle", version.ref = "spotless" }
9595
turbine = { module = "app.cash.turbine:turbine", version = "1.0.0" }
9696

97+
# Remove three-ten-abp once minSdkVersion is changed to 26 or later, and, instead use the
98+
# correspondingly-named classes from the java.time package, which should be drop-in replacements.
99+
# Do not use three-ten-abp in production code (it's only for tests) because it has performance
100+
# issues.
101+
testonly-three-ten-abp = { module = "com.jakewharton.threetenabp:threetenabp", version = "1.4.7" }
102+
97103
[bundles]
98104
kotest = ["kotest-runner", "kotest-assertions", "kotest-property", "kotest-property-arbs"]
99105
playservices = ["playservices-base", "playservices-basement", "playservices-tasks"]

0 commit comments

Comments
 (0)